RFC: Turn clone() into a function
#18919
Open
+219
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wording with functions This is in preparation of also exposing `clone()` as a function.
This is necessary for `clone()` which does not currently accept a parameter-less syntax, unless fully-qualified.
TimWolla
added a commit
to TimWolla/PHP-Parser
that referenced
this pull request
Jun 23, 2025
For use in stubs. see 9c7a3f8 see https://wiki.php.net/rfc/clone_with_v2 see php/php-src#18919
nikic
pushed a commit
to nikic/PHP-Parser
that referenced
this pull request
Jun 23, 2025
For use in stubs. see 9c7a3f8 see https://wiki.php.net/rfc/clone_with_v2 see php/php-src#18919
iluuu1994
approved these changes
Jun 23, 2025
| $a[0]->b = 0; | ||
| try { | ||
| $a = clone 0; | ||
| $a[0]->b = 0; |
| array_push($a->b, $c); | ||
| try { | ||
| $a = clone(null); | ||
| array_push($a->b, $c); |
| RETURN_THROWS(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This duplicates some logic from zend_vm_def.h. Can we consolidate? If not, we may at least link to the other function so that they are kept in-sync.
| } | ||
| } | ||
|
|
||
| zend_object *cloned; |
There was a problem hiding this comment.
Nit: Combine declaration & init.
| { | ||
| znode arg_node; | ||
|
|
||
| if (args->children != 1) { |
There was a problem hiding this comment.
Could be an ZEND_ASSERT for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/clone_with_v2
Spun out of #18747.