Fix -Wuseless-escape warnings emitted by re2c #19050
Merged
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re2c version 4 enabled some warnings by default. This fixes re2c code for the `-Wuseless-escape` warnings. There are two same issues reported. Issue: phpGH-17523 Closes: phpGH-17204
nielsdos
approved these changes
Jul 6, 2025
petk
added a commit
that referenced
this pull request
Jul 7, 2025
* PHP-8.3: Fix -Wuseless-escape warnings emitted by re2c (#19050)
petk
added a commit
that referenced
this pull request
Jul 7, 2025
* PHP-8.4: Fix -Wuseless-escape warnings emitted by re2c (#19050)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re2c version 4 enabled some warnings by default. This fixes re2c code for the
-Wuseless-escapewarnings.There are two same issues reported.
Issue: GH-17523
Closes: GH-17204
I'd suggest to split these issues into more steps to gradually fix all re2c warnings and enabling all warnings with
-Wflag on master (PHP-8.5) branch.Can someone perhaps review this one if this is correct?
I've tested this with re2c 1.0.3 and latest re2c version 4. And it seems the output of the generated files is the same before this patch and after.