Enable 64bit integer support on 32bit arch --enable-zend-int64
#19079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should go through the RFC process. There have been suggestions to drop 32-bit support, so I'm sure at least some people would object to expanding support further. I could see this as an alternative to dropping 32-bit support iff we also dropped 4-byte zend_long support, as that would align 32 and 64-bit. |
Girgias
reviewed
Jul 9, 2025
Comment on lines
+112
to
+145
| void gmp_set_zlong(mpz_t z, zend_long zlong) { | ||
| if (zlong <= GMP_SI_MAX && zlong >= GMP_SI_MIN) { | ||
| mpz_set_si(z, zlong); | ||
| } else if (zlong >= 0) { | ||
| mpz_import(z, 1, 1, sizeof(zend_long), 0, 0, &zlong); | ||
| } else { | ||
| mpz_import(z, 1, 1, sizeof(zend_long), 0, 0, &zlong); | ||
| mpz_neg(z, z); | ||
| } | ||
| } | ||
|
|
||
| int gmp_fits_zlong_p(mpz_t z) { | ||
| int result = 1; | ||
| mpz_t z_min_max; | ||
| zend_long min_max; | ||
|
|
||
| if (mpz_cmp_si(z, GMP_SI_MAX) > 0) { | ||
| min_max = ZEND_LONG_MAX; | ||
| mpz_init(z_min_max); | ||
| mpz_import(z_min_max, 1, 1, sizeof(zend_long), 0, 0, &min_max); | ||
| result = mpz_cmp(z, z_min_max) <= 0; | ||
| mpz_clear(z_min_max); | ||
| } else if (mpz_cmp_si(z, GMP_SI_MIN) < 0) { | ||
| min_max = ZEND_LONG_MIN; | ||
| mpz_init(z_min_max); | ||
| mpz_import(z_min_max, 1, 1, sizeof(zend_long), 0, 0, &min_max); | ||
| mpz_neg(z_min_max, z_min_max); | ||
| result = mpz_cmp(z, z_min_max) >= 0; | ||
| mpz_clear(z_min_max); | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
|
I have fixed some cases which failed due to SIZEOF_SIZE_T != SIZEOF_ZEND_LONG, but there are probably more. Currently, the test state is as follows: |
Yes, of course. At the current state I want to get to know the work needed to be done and do some benchmarks. For dropping 32-bit support entirely it seems to be to early at least for WebAssembly + there might be people hoping for supporting older (in some cases not that old) systems - so I don't thing it would go through currently. |
marc-mabe
force-pushed
the
int64
branch
4 times, most recently
from
3c8a5ac to
97bb3dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use 64bit integers on 32bit platforms if compiled with
--enable-zend-int64--enable-zend-int64)PHP_SYS_SIZE = [4|8])Zend/tests/andtests/ext/The main part is that
ZEND_ENABLE_ZVAL_LONG64 1gets defined.