ext/intl: GregorianCalendar addressing TODO. #19225
Open
+25
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using internally solely smart pointer for internal ICU class.
nielsdos
reviewed
Jul 24, 2025
| @@ -33,13 +33,23 @@ typedef struct { | |||
| intl_error err; | |||
|
|
|||
| // ICU calendar | |||
| #ifndef __cplusplus | |||
There was a problem hiding this comment.
I'm not so sure this trick is a good idea. Is there any guarantee in the C++ standard on the layout of a unique_ptr?
Perhaps we should convert the entire intl extension to C++ first before doing a change in a common file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using internally solely smart pointer for internal ICU class.