Fix _pdo_pgsql_trim_message bad access #19239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixyes
force-pushed
the
fix-pdo_pgsql_trim_message-bad-access
branch
from
e0f2741 to
ed2cefd
Compare
|
Hi @dixyes and thanks. Since it is a fix, it might be best to target the lowest supported branch where the bug occurs. 8.3 ? Is the bug reproducible reasonably ? Would be nice to have a test. |
dixyes
force-pushed
the
fix-pdo_pgsql_trim_message-bad-access
branch
from
ed2cefd to
7c1ee48
Compare
patch rebased. I've encountered this when running |
devnexen
reviewed
Jul 25, 2025
dixyes
force-pushed
the
fix-pdo_pgsql_trim_message-bad-access
branch
2 times, most recently
from
b69bc3f to
4a11ecb
Compare
dixyes
force-pushed
the
fix-pdo_pgsql_trim_message-bad-access
branch
from
4a11ecb to
f8940e3
Compare
devnexen
reviewed
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when input
const char *messageis empty string, the following line will access bad address