Deprecate constant redeclaration #19474
Merged
+19
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
constant-redeclaration
branch
from
a3ac541 to
9017c68
Compare
DanielEScherzer
requested changes
Aug 14, 2025
16 tasks
alexandre-daubois
force-pushed
the
constant-redeclaration
branch
2 times, most recently
from
7ad6db4 to
efec085
Compare
DanielEScherzer
approved these changes
Aug 16, 2025
|
@alexandre-daubois do you have merge rights? If not I can rebase this when I merge it so that we don't have more merge conflicts |
alexandre-daubois
force-pushed
the
constant-redeclaration
branch
from
efec085 to
788ac26
Compare
|
I don't, but PR rebased and conflicts resolved 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording now warns that redeclaring a constant will be an error in PHP 9, instead of a simple warning.
Should we keep the existing message and append to it, or change it to something like "Redeclaring constant %s is deprecated, this will throw an error in PHP 9"? I'm not sure what's the policy with error messages in this repo. I would say that changing the message to something more explicit is better.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_constant_redeclaration
Part of #19468, cc @DanielEScherzer