Zend: Convert certain fields to uint32_t #19479
Open
+48
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
reviewed
Aug 16, 2025
| @@ -23,6 +23,8 @@ | |||
| * php zend_vm_gen.php | |||
| */ | |||
|
|
|||
| #include <stdint.h> | |||
There was a problem hiding this comment.
This change is ignored (it doesn't end up in zend_vm_execute.h). I would recommend to add this include to zend_vm_execute.skl instead. (stdint.h is probably already included where zend_vm_execute.h is included, but this is still useful when looking at this file independently.)
There was a problem hiding this comment.
Oh I didn't even realize this header got added, will add to the skeleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These basically always assign to
uint32_tor be used as such anyway, so might as well make them this type properly so we don't need to think about C's implicit sign conversion rules