Deprecate disabling report_memleaks INI directive
#19481
Conversation
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
2 times, most recently
from
70f33af to
d6fdf2f
Compare
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
d6fdf2f to
6b546c7
Compare
alexandre-daubois
changed the title
report_memleaks INI directivereport_memleaks INI directive
php.ini-development
Outdated
| @@ -537,6 +537,7 @@ ignore_repeated_errors = Off | |||
| ; https://php.net/ignore-repeated-source | |||
| ignore_repeated_source = Off | |||
|
|
|||
| ; DEPRECATED: This INI setting is deprecated and will be removed in PHP 9.0. | |||
There was a problem hiding this comment.
This formatting is inconsistent with the other deprecated options, please unify.
I also wonder if there still is value in having this option readily presented in the example INI files. It's deprecated and only affects a debug build. Perhaps we can just remove this entire block for improved DX? If we want to keep it, the INI should be commented, though (to make sure it uses the built-in default).
There was a problem hiding this comment.
I'd say it should be kept. It costs nothing and this will avoid making exceptions for certain settings. Maybe it could also be easier for maintainers when upmerging.
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
6b546c7 to
9a42d86
Compare
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
9a42d86 to
e3f4fef
Compare
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
e3f4fef to
6313179
Compare
alexandre-daubois
force-pushed
the
report-memleaks-deprec
branch
from
6313179 to
a3b1595
Compare
|
Given the approvals and no other comments on #19481 (comment) I'm going ahead with merging. Should we decide to remove the INI from the example config, we can still do in a follow-up. |
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_report_memleaks_ini_directive