ext/pgsql: Refactor parameter parsing to remove manual usage of zend_wrong_parameters_count_error() #20068
+87
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blerg, really can't wait to get rid of this jank... |
Girgias
force-pushed
the
pgsql-zpp-refacto
branch
from
8a745ec to
346df2d
Compare
Girgias
force-pushed
the
pgsql-zpp-refacto
branch
from
346df2d to
2c3acf7
Compare
nielsdos
approved these changes
Oct 13, 2025
| zval dataset; | ||
| php_pgsql_fetch_hash(&dataset, result, row, row_is_null, PGSQL_ASSOC); | ||
|
|
||
| object_init_ex(return_value, ce); |
There was a problem hiding this comment.
This may be a pre-existing issue: but can't you make this object_init_ex call fail by providing an uninstantiable class (e.g. an interface, abstract class, ...). In that case, the code below may break.
There was a problem hiding this comment.
that sounds possible and very much a bug fix to me.
There was a problem hiding this comment.
I guess first thing is to fix the bug, then rebase on top of it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract pgsql changes from #20066