Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions Zend/tests/property_hooks/gh20270.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
--TEST--
GH-20270: Parent hook call with named arguments
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Missing --CREDITS--.

--FILE--
<?php

class A {
public mixed $prop1;
public mixed $prop2 {
set(mixed $custom) => $custom;
}
}

class B extends A {
public mixed $prop1 {
set {
parent::$prop1::set(value: 42);
parent::$prop1::set(unknown: 43);
}
}
public mixed $prop2 {
set {
parent::$prop2::set(custom: 42);
parent::$prop2::set(value: 43);
}
}
}

$b = new B();

try {
$b->prop1 = 0;
} catch (Error $e) {
echo $e->getMessage(), "\n";
}
var_dump($b->prop1);

try {
$b->prop2 = 0;
} catch (Error $e) {
echo $e->getMessage(), "\n";
}
var_dump($b->prop2);

?>
--EXPECT--
Unknown named parameter $unknown
int(42)
Unknown named parameter $value
int(42)
4 changes: 3 additions & 1 deletion Zend/zend_object_handlers.c
Original file line number Diff line number Diff line change
Expand Up @@ -1783,7 +1783,9 @@ ZEND_API zend_function *zend_get_property_hook_trampoline(
const zend_property_info *prop_info,
zend_property_hook_kind kind, zend_string *prop_name)
{
static const zend_arg_info arg_info[1] = {{0}};
static const zend_internal_arg_info arg_info[2] = {
{ .name = "value" }
};
zend_function *func;
if (EXPECTED(EG(trampoline).common.function_name == NULL)) {
func = &EG(trampoline);
Expand Down