Fix GH-20281: \Dom\Document::getElementById() is inconsistent after nodes are removed #20283
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r nodes are removed This worked for non-parsed elements already, but not for elements where xmlAddID() returns early due to the ID already existing. In that case what was missing is marking the attribute as an ID.
devnexen
approved these changes
Oct 24, 2025
devnexen
reviewed
Oct 24, 2025
| if (local_name_length == 2 && local_name[0] == 'i' && local_name[1] == 'd' && attr->node.ns == LXB_NS_HTML) { | ||
| xmlAddID(NULL, lxml_doc, value, lxml_attr); | ||
| if (xmlAddID(NULL, lxml_doc, value, lxml_attr) == 0) { | ||
| /* If the ID already exists, the ID attribute still needs to be marked as an ID. */ |
There was a problem hiding this comment.
just confused by one thing though, would it happen only if xmlAddID 1st arg was not NULL ?
There was a problem hiding this comment.
The first argument is a validation context. The only influence it has is in error reporting: if you pass a non-NULL pointer the error handler of that validation context will be used to emit an error saying there's a duplicate ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked for non-parsed elements already, but not for elements where xmlAddID() returns early due to the ID already existing. In that case what was missing is marking the attribute as an ID.