standard: Remove redundant code in range() #20432
Open
+8
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use signed integers (which fit the unsigned chars), then we can avoid the extra checks. Also move an exception check to the proper place.
Girgias
approved these changes
Nov 9, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
These conditions trace back to 30c0557#diff-9c1967d7282ea72ecea9d5dae0dab7349a34d48cc7a10ca38ff49a616f628e40, was mainly wondering if I had touched this or not during the refactoring I did of range() or not. And it seems I didn't.
This change makes a lot of sense to me, but maybe just add a comment above the definition of low and high to explain why we assign to int and not unsigned char?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use signed integers (which fit the unsigned chars), then we can avoid the extra checks. Also move an exception check to the proper place.