[WIP] PHP 8.5 release page #1454

saundefined · 2025-09-25T16:19:47Z

Preview: https://web-php-pr-1454.preview.thephp.foundation/releases/8.5/en.php

github-actions · 2025-09-25T16:21:27Z

🚀 Regression report for commit c3b4e7f is at https://web-php-regression-report-pr-1454.preview.thephp.foundation

github-actions · 2025-09-25T16:21:40Z

🚀 Preview for commit c3b4e7f can be found at https://web-php-pr-1454.preview.thephp.foundation

releases/8.5/release.inc

releases/8.5/languages/en.php

releases/8.5/release.inc

TimWolla · 2025-10-01T15:15:14Z

releases/8.5/release.inc

+$versions = ['PHP 8.1', 'PHP 8.2', 'PHP 8.3', 'PHP 8.4', 'PHP 8.5'];
+
+var_dump($versions[array_key_first($versions)]);
+// string(7) "PHP 8.1"


I find this example too simple to be useful, especially because $versions[0] works for a list. Perhaps we can find something with an associative array?

releases/8.5/release.inc

Co-authored-by: Tim Düsterhus <[email protected]>

TimWolla · 2025-10-04T13:23:15Z

releases/8.5/release.inc

+var_dump(
+    $version->withVersion('PHP 8.5'),
+    $version->version,
+);


Suggested change

var_dump(

$version->withVersion('PHP 8.5'),

$version->version,

);

var_dump($version->version);

// string(7) "PHP 8.4"

var_dump($version->withVersion('PHP 8.5')->version);

// string(7) "PHP 8.5"

var_dump($version->version);

// string(7) "PHP 8.4"

TimWolla · 2025-10-04T13:24:03Z

releases/8.5/release.inc

+    }
+}
+
+var_dump(new PhpVersion()->withVersion('PHP 8.5'));


Suggested change

var_dump(new PhpVersion()->withVersion('PHP 8.5'));

$version = new PhpVersion();

var_dump($version->version);

// string(7) "PHP 8.4"

var_dump($version->withVersion('PHP 8.5')->version);

To keep both in sync.

TimWolla · 2025-10-04T13:24:53Z

releases/8.5/release.inc

+                                <<<'PHP'
+#[\NoDiscard]
+function getPhpVersion(): string {
+	return 'PHP 8.4';


Suggested change

return 'PHP 8.4';

return 'PHP 8.5';

TimWolla · 2025-10-04T13:26:24Z

releases/8.5/release.inc

+$upcomingRelease = null;
+foreach ($php as $key => $version) {
+    if ($version['state'] === 'upcoming') {
+        $upcomingRelease = $version;
+        break;
+    }
+}


This is not a good example, because this could just be array_find().

TimWolla · 2025-10-04T13:26:40Z

releases/8.5/release.inc

+$upcomingRelease = array_first(
+    array_filter(
+        $php,
+        static fn($version) => $version['state'] === 'upcoming'
+    )
+);


TimWolla · 2025-10-04T13:28:55Z

releases/8.5/release.inc

+            <div class="php8-compare__main">
+                <div class="php8-compare__block example-contents">
+                    <div class="php8-compare__label">PHP &lt; 8.5</div>
+                    <div class="php8-code phpcode">
+                        <?php highlight_php_trimmed(
+                                <<<'PHP'
+$sh = curl_share_init();
+curl_share_setopt($sh, CURLSHOPT_SHARE, CURL_LOCK_DATA_DNS);
+curl_share_setopt($sh, CURLSHOPT_SHARE, CURL_LOCK_DATA_CONNECT);
+
+$ch1 = curl_init('https://php.net/');
+curl_setopt($ch1, CURLOPT_SHARE, $sh);
+curl_exec($ch1);
+
+$ch2 = curl_init('https://thephp.foundation/');
+curl_setopt($ch2, CURLOPT_SHARE, $sh);
+curl_exec($ch2);
+
+curl_share_close($sh);
+
+curl_close($ch1);
+curl_close($ch2);
+PHP
+
+                        ); ?>
+                    </div>
+                </div>
+                <div class="php8-compare__arrow"></div>
+                <div class="php8-compare__block example-contents" style="display: table;">
+                    <div class="php8-compare__label php8-compare__label_new">PHP 8.5</div>
+                    <div class="php8-code phpcode" style="display: table-cell;">
+                        <?php highlight_php_trimmed(
+                                <<<'PHP'
+$sh = curl_share_init_persistent([
+    CURL_LOCK_DATA_DNS,
+    CURL_LOCK_DATA_CONNECT
+]);
+
+$ch1 = curl_init('https://php.net/');
+curl_setopt($ch1, CURLOPT_SHARE, $sh);
+curl_exec($ch1);
+
+$ch2 = curl_init('https://thephp.foundation/');
+curl_setopt($ch2, CURLOPT_SHARE, $sh);
+curl_exec($ch2);
+
+curl_close($ch1);
+curl_close($ch2);
+PHP
+                        ); ?>
+                    </div>
+                </div>
+            </div>


This comparison is not really meaningful to understand what has changed. At least some explanation is necessary. curl_close() should be removed in all cases, since it is useless with 8.0 and deprecated with 8.5.

TimWolla · 2025-10-04T13:31:23Z

releases/8.5/release.inc

+    #[DataProvider('subtractionProvider')]
+    public function testSubtraction(
+        int $minuend,
+        int $subtrahend,
+        int $result
+    ): void
+    {
+        $this->assertSame(
+            $result,
+            Calculator::subtract($minuend, $subtrahend)
+        );
+    }


This should be kept in sync with the 8.5 version. Unfortunately the 8.5 version can't yet use PHPUnit, since sebastianbergmann/phpunit#6136 is not implemented yet. So both should use some “generic test framework”.

/cc @sebastianbergmann

TimWolla · 2025-10-04T13:33:03Z

releases/8.5/release.inc

+    ) {}
+
+    public function withVersion(string $version) {
+        return clone($this, ['version' => $version]);


Suggested change

return clone($this, ['version' => $version]);

return clone($this, [

'version' => $version,

]);

To reduce line length a little more.

TimWolla · 2025-10-04T13:33:40Z

releases/8.5/release.inc

+                    <div class="php8-code phpcode">
+                        <?php highlight_php_trimmed(
+                                <<<'PHP'
+function getPhpVersion(): string {


Suggested change

function getPhpVersion(): string {

function getPhpVersion(): string

{

To follow the PER CS code style.

TimWolla · 2025-10-04T13:33:45Z

releases/8.5/release.inc

+                        <?php highlight_php_trimmed(
+                                <<<'PHP'
+#[\NoDiscard]
+function getPhpVersion(): string {


Suggested change

function getPhpVersion(): string {

function getPhpVersion(): string

{

TimWolla · 2025-10-04T13:35:04Z

releases/8.5/release.inc

+                <ul>
+                    <li>Property Promotion is now available for <code>final</code></li>
+                    <li>Attributes are now available for constants</li>
+                    <li>Attribute <code>#[\Override]</code> now works on properties</li>


Suggested change

<li>Attribute <code>#[\Override]</code> now works on properties</li>

<li>Attribute <a href="/manual/en/class.override.php"><code>#[\Override]</code></a> now works on properties</li>

TimWolla · 2025-10-04T13:35:18Z

releases/8.5/release.inc

+                    <li>Property Promotion is now available for <code>final</code></li>
+                    <li>Attributes are now available for constants</li>
+                    <li>Attribute <code>#[\Override]</code> now works on properties</li>
+                    <li>Attribute <code>#[\Deprecated]</code> available for traits</li>


Suggested change

<li>Attribute <code>#[\Deprecated]</code> available for traits</li>

<li>Attribute <a href="/manual/en/class.deprecated.php"><code>#[\Deprecated]</code></a> available for traits</li>

TimWolla · 2025-10-04T13:35:57Z

releases/8.5/release.inc

+                    <li>Attribute <code>#[\Deprecated]</code> available for traits</li>
+                    <li>Asymmetric Visibility for Static Properties</li>
+                    <li>New <code>#[\DelayedTargetValidation]</code> attribute is available</li>
+                    <li>New <code>get_error_handler()</code>, <code>get_exception_handler()</code> functions, and <code>Closure::getCurrent</code> method are available.</li>


Link to:

https://www.php.net/manual/en/function.get-error-handler.php

https://www.php.net/manual/en/function.get-exception-handler.php

TimWolla · 2025-10-04T13:36:12Z

releases/8.5/release.inc

+                    <li>Attribute <code>#[\Deprecated]</code> available for traits</li>
+                    <li>Asymmetric Visibility for Static Properties</li>
+                    <li>New <code>#[\DelayedTargetValidation]</code> attribute is available</li>
+                    <li>New <code>get_error_handler()</code>, <code>get_exception_handler()</code> functions, and <code>Closure::getCurrent</code> method are available.</li>


Closure::getCurrent() should be a separate bullet point.

TimWolla · 2025-10-04T13:36:37Z

releases/8.5/release.inc

+        for ($i = -10; $i <= 10; $i++) {
+            yield [$i, $i, 0];
+            yield [$i, 0, $i];
+            yield [0, $i, ($i * -1)];


Suggested change

yield [0, $i, ($i * -1)];

yield [0, $i, -$i];

Consistency

Add PHP 8.5 release page

2614191

saundefined added the Status: Preview Allowed label Sep 25, 2025

TimWolla reviewed Sep 26, 2025

View reviewed changes

releases/8.5/release.inc Outdated Show resolved Hide resolved

wip

ec7b3ef

saundefined added Status: Preview Allowed and removed Status: Preview Allowed labels Oct 1, 2025

wip

5fc81d6

saundefined added Status: Preview Allowed and removed Status: Preview Allowed labels Oct 1, 2025

TimWolla reviewed Oct 1, 2025

View reviewed changes

vudaltsov reviewed Oct 3, 2025

View reviewed changes

releases/8.5/release.inc Outdated Show resolved Hide resolved

vudaltsov reviewed Oct 3, 2025

View reviewed changes

releases/8.5/release.inc Outdated Show resolved Hide resolved

TimWolla reviewed Oct 3, 2025

View reviewed changes

releases/8.5/release.inc Outdated Show resolved Hide resolved

releases/8.5/release.inc Outdated Show resolved Hide resolved

Apply suggestions from code review

1027001

Co-authored-by: Tim Düsterhus <[email protected]>

saundefined added Status: Preview Allowed and removed Status: Preview Allowed labels Oct 3, 2025

wip

4c0fe2b

saundefined added Status: Preview Allowed and removed Status: Preview Allowed labels Oct 3, 2025

wip

6e7045f

saundefined added Status: Preview Allowed and removed Status: Preview Allowed labels Oct 3, 2025

TimWolla reviewed Oct 4, 2025

View reviewed changes

-var_dump(
-    $version->withVersion('PHP 8.5'),
-    $version->version,
-);
+var_dump($version->version);
+// string(7) "PHP 8.4"
+var_dump($version->withVersion('PHP 8.5')->version);
+// string(7) "PHP 8.5"
+var_dump($version->version);
+// string(7) "PHP 8.4"

	function getPhpVersion(): string {
	function getPhpVersion(): string
	{

	<li>Attribute <code>#[\Override]</code> now works on properties</li>
	<li>Attribute <a href="/manual/en/class.override.php"><code>#[\Override]</code></a> now works on properties</li>

	<li>Attribute <code>#[\Deprecated]</code> available for traits</li>
	<li>Attribute <a href="/manual/en/class.deprecated.php"><code>#[\Deprecated]</code></a> available for traits</li>

[WIP] PHP 8.5 release page #1454

Are you sure you want to change the base?

[WIP] PHP 8.5 release page #1454

Conversation

saundefined commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saundefined commented Sep 25, 2025 •

edited

Loading

github-actions bot commented Sep 25, 2025 •

edited

Loading

github-actions bot commented Sep 25, 2025 •

edited

Loading