-
Notifications
You must be signed in to change notification settings - Fork 19
Wildcard support #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard support #113
Conversation
5c3bb6a
to
6dc5390
Compare
@@ -4,6 +4,7 @@ php: | |||
- 5.4 | |||
|
|||
before_script: | |||
- composer require "symfony/symfony" "2.6.*" --no-update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the deprecation errors..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -9,6 +9,7 @@ | |||
use PHPCR\SimpleCredentials; | |||
use PHPCR\Shell\Transport\TransportRegistryInterface; | |||
use PHPCR\SessionInterface; | |||
use PHPCR\Shell\Query\PhpcrRepository; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
if we want to split it out, the correct thing would be to have phpcr/finder or phpcr/phpcr-finder and then have a doctrine/glob-finder or whatever describes that well. or just have it in doctrine/phpcr-odm, using the phpcr-finder if that helps. is there code to be shared for orm glob finding? should it be doctrine/glob-finder and then a phpcr-finder built on top of that? |
Hmm. Well, going down that route there should also be |
doctrine does provide a bunch of generically useful things not tied to object-relational/document-mappers. so doctrine/globfinder could be a thing i guess, if there is enough code to make it worthwile. |
@Ocramius @beberlei do you see any value in adding this library to the Doctrine organization? It is a library for finding documents based on glob patterns (e.g. |
@dantleech yes, it could be moved to |
maybe we should move |
Yeah the |
I would avoid coupling with the What about defining a package like |
Well, the concept could apply equally to any hierarchical data stores, so I wouldn't feel strongly about putting it in a |
like |
Also: we can discuss this on friday/saturday if you are at the mayflower hackaton |
I guess the place that makes most sense would be |
there are a couple of separate libraries in doctrine, like annotations. i would prefer to have this in the doctrine organization, as a statement to its role as general glob finder for database-like things. but yeah, lets see on friday :-) |
Added jackalope-fs transport
$level = error_reporting(0); | ||
$helper = parent::get($name); | ||
error_reporting($level); | ||
return $helper; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. remove this workaround
Closes: #80
Support wildcards via. the CMF resource bundles PhpcrTraversalFinder
class.
Todo:
For
node:list
: