Skip to content

Extractor: Account for attribute changes #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2025

Conversation

DanielEScherzer
Copy link
Contributor

Ignore the Since and Until attributes that the extractor adds, and also ignore if the attributes are grouped differently for simplicity.

@DanielEScherzer
Copy link
Contributor Author

@ondrejmirtes the "Update stubs" job is failing because of "Error: Input required and not supplied: token"

@DanielEScherzer
Copy link
Contributor Author

This one I did test with https://github.com/DanielEScherzer/php-8-stubs/actions/runs/17108437941/job/48523372809 and it worked, DanielEScherzer@1da7e0b is what the bot created

Ignore the `Since` and `Until` attributes that the extractor adds, and also
ignore if the attributes are grouped differently for simplicity.
@ondrejmirtes ondrejmirtes merged commit 8792897 into phpstan:main Aug 20, 2025
2 checks passed
@ondrejmirtes
Copy link
Member

Great, thank you!

@DanielEScherzer DanielEScherzer deleted the patch-4 branch August 21, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants