Add numeric check on unary plus and unary minus #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
unaryCheck
branch
2 times, most recently
from
c0d321f to
dc350fa
Compare
VincentLanglet
force-pushed
the
unaryCheck
branch
from
dc350fa to
b383425
Compare
ondrejmirtes
requested changes
Jul 17, 2025
| @@ -6,29 +6,29 @@ | |||
|
|
|||
| [PHPStan](https://phpstan.org/) focuses on finding bugs in your code. But in PHP there's a lot of leeway in how stuff can be written. This repository contains additional rules that revolve around strictly and strongly typed code with no loose casting for those who want additional safety in extremely defensive programming: | |||
|
|
|||
| | Configuration Parameters | Rule Description | | |||
There was a problem hiding this comment.
The README diff is unreadable, please make it minimal.
| @@ -106,6 +106,10 @@ conditionalTags: | |||
| phpstan.rules.rule: %strictRules.numericOperandsInArithmeticOperators% | |||
| PHPStan\Rules\Operators\OperandInArithmeticPreIncrementRule: | |||
| phpstan.rules.rule: %strictRules.numericOperandsInArithmeticOperators% | |||
| PHPStan\Rules\Operators\OperandInArithmeticUnaryMinusRule: | |||
| phpstan.rules.rule: %strictRules.numericOperandsInArithmeticOperators% | |||
There was a problem hiding this comment.
Only for bleeding edge. Please check 1.x to see how it was done (it's an array).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation
$a + $band$a - $bwere checked but it was mising for the unary usage of these operators+$aor-$a.Then, I plan to add such check for bitwise operators:
&(AND)|(OR)<<(Left shift)>>(Right shift)^(XOR)I assume it should be behind a new config option
numericOperandsInBitwiseOperators@ondrejmirtes ?