Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a report on Discourse, investigations have revealed that
SIGRTMIN
are defined differently in Debian (glibc-based) and Alpine (musl-based). Hence, sending signals relative toSIGRTMIN
is going to be an issue on Debian as we build the pihole-FTL binaries on Alpine. Change the documentation to use fixed signals (instead of relative ones) to fix this. Signals relative to the constantSIGRTMIN
have been added as there is a certain number ambiguity underglibc
(see man 7 signals). However, this ambiguity does not exist inmusl
-based binaries.Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase
)