Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about setting a blank password in docker #1216

Merged
merged 3 commits into from
Mar 21, 2025
Merged

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Companion/folllowup to pi-hole/docker-pi-hole#1778

includes an extra commit that makes the devcontainer usable on Mac - minor tweak, no sense in doing a whole PR for it - it has the same logic as pi-hole/FTL#2152


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team March 20, 2025 17:24
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit e3afdc3
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/67dc501206f5a20008535e04
😎 Deploy Preview https://deploy-preview-1216--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PromoFaux PromoFaux merged commit 75fe1ff into master Mar 21, 2025
10 checks passed
@PromoFaux PromoFaux deleted the tweak/passwords branch March 21, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants