Skip to content

Conversation

@yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 17, 2025

What does this PR aim to accomplish?:

mkdocs-material is in maintenance mode and their creators build a new site generation tool called zensical (here). It offers a back-wards compatibility to mkdocs-material so the transition is quite smooth.

This is work in progress

Internal

  • Replace markdown_include with snippets as the former did not work well with zensical (adapts Add deprecation notice to OpenVPN pages [v6] #1029)
  • Switch to native zensical.toml
  • Decide which theme should be used (classic vs modern)
  • Port navigation
  • Update Readme.md
  • Table of contents > On this page in right navigation panel
  • Check snippts (OpenVPN deprecation notice) working
  • Tooltip Footnotes
  • Abbreviations work when defined in same page, but glossary does not; Tracking

External


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team as a code owner November 17, 2025 19:25
@yubiuser yubiuser marked this pull request as draft November 17, 2025 19:25
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit f0ea511
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/691f45c2b58a650008a13f2b
😎 Deploy Preview https://deploy-preview-1311--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rdwebdesign
Copy link
Member

Figure out what replaces theme/features: search.suggest and search.share

I'm not sure if these options are available on the new system, but do we need them?

search.share only adds an icon to the search bar that copies a link to clipboard. The link will include the query string ?q=<search_string>, link this: https://docs.pi-hole.net/?q=dns.

search.suggest is useful (it works like auto-completion on the search field), but I'm not sure if this is available.

The new search window is a little different, but it also shows all results in real time while you type the search string, like mkdocs search. Not sure if the suggestions are needed.

@yubiuser
Copy link
Member Author

The whole search was completely re-implemented. We probably don't need search.share (who is linking to search results which can change on every page change?); search.suggest is nice and might be implemented as they work on the search functionality. I don't think it is a big loss for both option, but just kept track of things that we use and which are currently not implemented.


Note: I removed markdown_extensions which were unused without listing them above.

@rdwebdesign
Copy link
Member

Check how to implement not_in_nav

Not sure if we really need this.

Decide which theme should be used (classic vs modern)

Can you provide a screenshot using the "classic" theme?

@yubiuser
Copy link
Member Author

Not sure if we really need this.

It depends if they implement warning about files not included in the navigation. Tracking here: zensical/zensical#124


Can you provide a screenshot using the "classic" theme?

This is 1:1 the current Materials for MkDocs theme we use. So all screenshots are at https://docs.pi-hole.net/
(This is why I used the 'modern' them for the Nelify preview so we can easily compare)

@mwoolweaver
Copy link
Contributor

(This is why I used the 'modern' them for the Nelify preview so we can easily compare)

i vote modern. (though i'm sure my vote doesnt count much😂😂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants