Fix handling of boolean values in JSql implementation #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being treated as json values) in the JSql implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSql implementation has a bug whereby you cannot query boolean values. The cause of the bug is due to missing implementation for handling boolean values, causing all boolean values to be saved as "json" in the database. This means that entries for the boolean values are saved as :
nVl=null, sVl=null, tVl=true/false.I've updated the insert/upsert logic to save boolean values as
nVl=1/0, sVl=true/false, tVl=true/false.However, in order to support querying legacy entries that are already saved to the database as json, I've updated the building of preparedstatement for queries to query
tVl=true/falsefor boolean values, sincetVlis set for both legacy and new values. I've added comments above the relevant code block to explain why we don't use preparedStatement.setBoolean instead for future reference.