Skip to content

[helm]: add FAIL_ON_EMPTY_METRICS and MONITORING to default values. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiamran merged 3 commits into from
Dec 8, 2025
Merged

[helm]: add FAIL_ON_EMPTY_METRICS and MONITORING to default values. #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81656f0
[helm]: add FAIL_ON_EMPTY_METRICS and MONITORING to default values.
Dec 5, 2025
f1f5c21
[gh-action]: bump k8s testing versions
Dec 5, 2025
0296f95
[gh-action]: bump k8s testing versions
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/github-actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
needs: [lint]
strategy:
matrix:
k8s: [ 1.21, 1.23, 1.24, 1.25 ]
k8s: [ 1.29, 1.31, 1.32, 1.33, 1.34 ]

runs-on: ubuntu-latest
steps:
Expand Down
8 changes: 8 additions & 0 deletions helm-chart-sources/k8s-metrics-collector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ environment:
# by the Prometheus server URL as generated by the installation.
PROMETHEUS_URL: 'http://prometheus-kube-prometheus-prometheus:9090'

# When enabled, the agent will exit with a failure status if no metrics are collected during a run. This helps detect collection issues early in monitoring pipelines.
FAIL_ON_EMPTY_METRICS: 'true'

# Sends monitoring metrics to UmbrellaCost CloudWatch account using Embedded Metric Format.
# Only operational metrics are transmitted. No sensitive data is included.
MONITORING: 'cloudwatch-emf'


# The following settings are relevant only in some cases. Set them when it applies to your case according to the
# description. Do not set them when they are not required.

Expand Down