Skip to content

Conversation

@YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 7, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

增加了日志备份和恢复的兼容性章节。
Added a paragraph that describes the compatibility between log backup and snapshot restore.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2025
@YuJuncen YuJuncen changed the title "br: 新增日志备份与恢复之兼容性" br: Added Compatibility between Log Backup and PiTR Mar 7, 2025
@lilin90 lilin90 changed the title br: Added Compatibility between Log Backup and PiTR br: add compatibility between log backup and PITR Mar 11, 2025
@lilin90 lilin90 added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Mar 11, 2025
@lilin90 lilin90 self-assigned this Mar 11, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 11, 2025
@lilin90 lilin90 added the v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. label Mar 11, 2025
@lilin90 lilin90 requested a review from Copilot March 27, 2025 05:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new documentation section in br/br-pitr-manual.md that explains how an ongoing log backup interacts with snapshot restore and point in time restore operations.

  • Introduces a section titled "Compatibility between Ongoing Log Backup and Restore" for v9.0.0 and later.
  • Details the conditions under which snapshot restore can be performed when a log backup task exists, and provides guidance for handling point in time restores.

@lilin90
Copy link
Member

lilin90 commented Apr 8, 2025

/bot-review

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

✅ AI review completed, 7 comments generated.

lilin90 and others added 2 commits April 9, 2025 15:56
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lilin90 lilin90 requested a review from BornChanger April 9, 2025 07:58
@lilin90
Copy link
Member

lilin90 commented Apr 9, 2025

/test pull-verify

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 9, 2025

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: xixirangrang <[email protected]>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 10, 2025
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 10, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-09 12:22:10.636442761 +0000 UTC m=+2259024.320678857: ☑️ agreed by hfxsd.
  • 2025-04-10 02:25:58.951290547 +0000 UTC m=+2309652.635526640: ☑️ agreed by lilin90.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit 6381c81 into pingcap:master Apr 10, 2025
9 checks passed
@lilin90 lilin90 added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 11, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants