-
Notifications
You must be signed in to change notification settings - Fork 701
feat: add navicat into the supported gui part (#21253) #21261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add navicat into the supported gui part (#21253) #21261
Conversation
@Icemap This PR has conflicts, I have hold it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, an automated cherry-pick, is intended to enhance the TiDB documentation by updating the list of supported GUI tools. It specifically adds Navicat and provides updated information for several other popular tools, making the documentation more comprehensive and helpful for users. Additionally, it introduces a new section for users to find help and support. However, it's critical to note that the patch currently includes unresolved Git merge conflict markers, which will need to be addressed manually.
Highlights
- Documentation Update: This pull request aims to update the
develop/dev-guide-third-party-support.md
file to provide more comprehensive information about supported GUI tools for TiDB. - Addition of Navicat Support: Navicat (version 17.1.6) has been added to the list of fully supported GUI tools, including a direct link to its connection tutorial.
- Expansion and Updates to GUI Tool List: The existing list of supported GUI tools has been expanded and updated to include Beekeeper Studio (4.3.0), JetBrains DataGrip (2023.2.1), DBeaver (updated to 23.0.3), and Visual Studio Code (1.72.0), along with their latest tested versions and relevant tutorial links.
- New 'Need Help?' Section: A new section titled 'Need help?' has been introduced at the end of the document, providing quick access to community support channels (Discord, Slack) and options to submit support tickets for both TiDB and TiDB Cloud platforms.
- Unresolved Merge Conflict: The patch, which is an automated cherry-pick, has introduced Git merge conflict markers (
<<<<<<< HEAD
,=======
,>>>>>>>
) into thedevelop/dev-guide-third-party-support.md
file. This indicates that the cherry-pick resulted in an unresolved conflict that requires manual intervention before the pull request can be properly merged.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds Navicat to the list of supported GUIs in the third-party support documentation. The table formatting could be improved for readability, and the merge conflict markers should be removed. The utm_source
parameter in the Discord URL is also noted for potential removal.
<<<<<<< HEAD | ||
| GUI | Latest tested version | Support level | Tutorial | | ||
| - | - | - | - | | ||
| [DBeaver](https://dbeaver.io/) | 23.0.1 | Full | N/A | No newline at end of file | ||
| [DBeaver](https://dbeaver.io/) | 23.0.1 | Full | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there's some leftover code from a merge conflict. The lines starting with <<<<<<< HEAD
and ending with =======
should be removed, as they are artifacts of the merging process and not actual content.1
Style Guide References
Footnotes
Ask the community on [Discord](https://discord.gg/DQZ2dy3cuc?utm_source=doc) or [Slack](https://slack.tidb.io/invite?team=tidb-community&channel=everyone&ref=pingcap-docs), or [submit a support ticket](https://tidb.support.pingcap.com/). | ||
|
||
</CustomContent> | ||
>>>>>>> 6a3dc92156 (feat: add navicat into the supported gui part (#21253)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there's some leftover code from a merge conflict. The lines starting with >>>>>>> 6a3dc92156 (feat: add navicat into the supported gui part (#21253))
should be removed, as they are artifacts of the merging process and not actual content.1
Style Guide References
Footnotes
| GUI | Latest tested version | Support level | Tutorial | | ||
|-----------------------------------------------------------|-----------------------|---------------|--------------------------------------------------------------------------------------| | ||
| [Beekeeper Studio](https://www.beekeeperstudio.io/) | 4.3.0 | Full | N/A | | ||
| [JetBrains DataGrip](https://www.jetbrains.com/datagrip/) | 2023.2.1 | Full | [Connect to TiDB with JetBrains DataGrip](/develop/dev-guide-gui-datagrip.md) | | ||
| [DBeaver](https://dbeaver.io/) | 23.0.3 | Full | [Connect to TiDB with DBeaver](/develop/dev-guide-gui-dbeaver.md) | | ||
| [Visual Studio Code](https://code.visualstudio.com/) | 1.72.0 | Full | [Connect to TiDB with Visual Studio Code](/develop/dev-guide-gui-vscode-sqltools.md) | | ||
| [Navicat](https://www.navicat.com) | 17.1.6 | Full | [Connect to TiDB with Navicat](/develop/dev-guide-gui-navicat.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table formatting in markdown could be improved for readability. Consider aligning the columns using spaces to make it easier to read the table in the raw markdown format. Also, ensure that the table headers and content are consistent in terms of capitalization and style.1
Style Guide References
| GUI | Latest tested version | Support level | Tutorial | | |
|-----------------------------------------------------------|-----------------------|---------------|--------------------------------------------------------------------------------------| | |
| [Beekeeper Studio](https://www.beekeeperstudio.io/) | 4.3.0 | Full | N/A | | |
| [JetBrains DataGrip](https://www.jetbrains.com/datagrip/) | 2023.2.1 | Full | [Connect to TiDB with JetBrains DataGrip](/develop/dev-guide-gui-datagrip.md) | | |
| [DBeaver](https://dbeaver.io/) | 23.0.3 | Full | [Connect to TiDB with DBeaver](/develop/dev-guide-gui-dbeaver.md) | | |
| [Visual Studio Code](https://code.visualstudio.com/) | 1.72.0 | Full | [Connect to TiDB with Visual Studio Code](/develop/dev-guide-gui-vscode-sqltools.md) | | |
| [Navicat](https://www.navicat.com) | 17.1.6 | Full | [Connect to TiDB with Navicat](/develop/dev-guide-gui-navicat.md) | | |
| GUI | Latest tested version | Support level | Tutorial | | |
|-----------------------------------------------------------|-----------------------|---------------|--------------------------------------------------------------------------------------| | |
| [Beekeeper Studio](https://www.beekeeperstudio.io/) | 4.3.0 | Full | N/A | | |
| [JetBrains DataGrip](https://www.jetbrains.com/datagrip/) | 2023.2.1 | Full | [Connect to TiDB with JetBrains DataGrip](/develop/dev-guide-gui-datagrip.md) | | |
| [DBeaver](https://dbeaver.io/) | 23.0.3 | Full | [Connect to TiDB with DBeaver](/develop/dev-guide-gui-dbeaver.md) | | |
| [Visual Studio Code](https://code.visualstudio.com/) | 1.72.0 | Full | [Connect to TiDB with Visual Studio Code](/develop/dev-guide-gui-vscode-sqltools.md) | | |
| [Navicat](https://www.navicat.com) | 17.1.6 | Full | [Connect to TiDB with Navicat](/develop/dev-guide-gui-navicat.md) | |
Footnotes
|
||
<CustomContent platform="tidb"> | ||
|
||
Ask the community on [Discord](https://discord.gg/DQZ2dy3cuc?utm_source=doc) or [Slack](https://slack.tidb.io/invite?team=tidb-community&channel=everyone&ref=pingcap-docs), or [submit a support ticket](/support.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL https://discord.gg/DQZ2dy3cuc?utm_source=doc
includes a utm_source
parameter. While this is not inherently an issue, consider if tracking the source within Discord/Slack is necessary. If not, removing the parameter would make the URL cleaner.1
Style Guide References
Ask the community on [Discord](https://discord.gg/DQZ2dy3cuc?utm_source=doc) or [Slack](https://slack.tidb.io/invite?team=tidb-community&channel=everyone&ref=pingcap-docs), or [submit a support ticket](/support.md). | |
Ask the community on [Discord](https://discord.gg/DQZ2dy3cuc) or [Slack](https://slack.tidb.io/invite?team=tidb-community&channel=everyone&ref=pingcap-docs), or [submit a support ticket](/support.md). |
Footnotes
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
60f3593
to
42beae6
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #21253
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?