Skip to content

Conversation

@lilin90
Copy link
Member

@lilin90 lilin90 commented Jul 9, 2025

What is changed, added or deleted? (Required)

Updates "On the Create Cluster page, Serverless is selected by default." to "On the Create Cluster page, Starter is selected by default." in develop/dev-guide-build-cluster-in-cloud.md.

Note

The change for release-8.5 has been involved in #21523. So I won't cherry pick this PR to release-8.5.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 self-assigned this Jul 9, 2025
@ti-chi-bot ti-chi-bot bot added the area/develop This PR relates to the area of TiDB App development. label Jul 9, 2025
@lilin90 lilin90 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed area/develop This PR relates to the area of TiDB App development. labels Jul 9, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @lilin90, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for creating clusters in the cloud. The primary goal is to ensure the guide accurately reflects the current user interface, specifically correcting the default cluster type selection from 'Serverless' to 'Starter' on the 'Create Cluster' page.

Highlights

  • Documentation Update: The guide for building clusters in the cloud (develop/dev-guide-build-cluster-in-cloud.md) has been updated to reflect that 'Starter' is now the default selection on the 'Create Cluster' page, replacing the previous 'Serverless' designation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2025
@lilin90 lilin90 added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. rename-serverless This PR is caused by renaming TiDB Cloud Serverless. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates 'Serverless' to 'Starter' on the cluster creation page. To maintain consistency as per the style guide, I recommend updating all instances of 'Serverless' to 'Starter' throughout the documentation.

@lilin90 lilin90 requested a review from qiancai July 9, 2025 03:51
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2025
@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-09 05:52:49.777217502 +0000 UTC m=+2065422.500396491: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 9, 2025
@lilin90 lilin90 added the lgtm label Jul 9, 2025
@lilin90 lilin90 removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Aug 11, 2025
Updated the documentation to specify that the {{{ .starter }}} cluster in TiDB Cloud was formerly known as Serverless, providing clearer context for users familiar with the previous terminology.
@ti-chi-bot ti-chi-bot bot added the area/develop This PR relates to the area of TiDB App development. label Aug 11, 2025
Copy link
Member Author

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
@lilin90
Copy link
Member Author

lilin90 commented Aug 12, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 12, 2025
@qiancai qiancai merged commit bd9b17a into pingcap:master Aug 12, 2025
9 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Aug 12, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #21581.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #21582.

qiancai pushed a commit that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/develop This PR relates to the area of TiDB App development. area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. rename-serverless This PR is caused by renaming TiDB Cloud Serverless. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants