Skip to content

Conversation

@sunxiaoguang
Copy link
Contributor

@sunxiaoguang sunxiaoguang commented Oct 12, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @sunxiaoguang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the TiDB Cloud serverless limitations documentation to include important information regarding database client connection lifetimes. The change aims to inform users about potential connection terminations for long-lived connections and provides a recommended starting point for connection lifetime settings to help prevent unexpected service impacts.

Highlights

  • Documentation Update: Added a new limitation to the serverless-limitations.md file, specifically detailing the maximum lifetime of database client connections.
  • Connection Lifetime Guidance: The documentation now advises that database client connections held open longer than 30 minutes may be terminated unexpectedly, recommending an initial 5-minute maximum connection lifetime to manage potential tail latency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an important limitation regarding the maximum lifetime of database connections for serverless clusters. My review includes a suggestion to correct a typo and rephrase the new content for better clarity and adherence to the documentation style guide, making the recommendation more direct for the user.

@qiancai qiancai self-assigned this Oct 14, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2025
@sunxiaoguang sunxiaoguang force-pushed the connection_lifetime_limitation branch from e1e1ef3 to c88d517 Compare October 24, 2025 09:57
@sunxiaoguang sunxiaoguang force-pushed the connection_lifetime_limitation branch from c88d517 to 428018f Compare October 24, 2025 11:27
Signed-off-by: Xiaoguang Sun <[email protected]>
@sunxiaoguang
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation about configuring the maximum lifetime of connections to prevent disruptions. The changes are made in dev-guide-connection-parameters.md and tidb-cloud/serverless-limitations.md.

My review focuses on improving clarity and adhering to the documentation style guide. I've suggested rephrasing some sentences to use active voice and address the user directly, which makes the content more engaging and easier to understand. I also recommended a formatting change for consistency with the rest of the document and the style guide.

Overall, the changes are good and provide valuable information for users.

Comment on lines +41 to +65
<SimpleTab>
<div label="HikariCP">

- **maxLifetime**: The maximum lifetime of a connection in the pool.

</div>

<div label="tomcat-jdbc">

- **maxAge**: The maximum lifetime of a connection in the pool.

</div>

<div label="c3p0">

- **maxConnectionAge**: The maximum lifetime of a connection in the pool.

</div>

<div label="dbcp">

- **maxConnLifetimeMillis**: The maximum lifetime of a connection in the pool.

</div>
</SimpleTab>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

According to the style guide, options should be enclosed in backticks.1 To ensure consistency throughout the document, I suggest wrapping these parameter names in backticks.

<SimpleTab>
<div label="HikariCP">

- `maxLifetime`: The maximum lifetime of a connection in the pool.

</div>

<div label="tomcat-jdbc">

- `maxAge`: The maximum lifetime of a connection in the pool.

</div>

<div label="c3p0">

- `maxConnectionAge`: The maximum lifetime of a connection in the pool.

</div>

<div label="dbcp">

- `maxConnLifetimeMillis`: The maximum lifetime of a connection in the pool.

</div>
</SimpleTab>

Style Guide References

Footnotes

  1. The style guide specifies that options should be enclosed in backticks.

likidu and others added 2 commits October 24, 2025 19:56
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@likidu
Copy link
Collaborator

likidu commented Oct 24, 2025

LGTM

@sunxiaoguang sunxiaoguang changed the title [WIP] Add maximum lifetime of connections Add maximum lifetime of connections Oct 24, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2025
Signed-off-by: Xiaoguang Sun <[email protected]>
@qiancai qiancai added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. and removed missing-translation-status This PR does not have translation status info. labels Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants