Skip to content

Conversation

@qiancai
Copy link
Collaborator

@qiancai qiancai commented Oct 24, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add notes to clarify the availability of FULLTEXT syntax and indexes for different product options.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@gemini-code-assist
Copy link

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the TiDB documentation by providing precise details on the availability of FULLTEXT syntax and indexes. The update clarifies which TiDB Cloud tiers and regions offer this feature, while also explicitly stating its absence in TiDB Self-Managed and TiDB Cloud Dedicated environments. This change aims to improve user understanding of feature compatibility across different TiDB deployment options.

Highlights

  • Documentation Update for FULLTEXT Syntax: This pull request updates the mysql-compatibility.md documentation to provide clearer information regarding the support for FULLTEXT syntax and indexes within the TiDB ecosystem.
  • Clarification on TiDB Cloud Support: A new note has been added specifying that FULLTEXT syntax and indexes are currently only supported in starter and essential TiDB Cloud clusters within certain AWS regions.
  • Limitations for Other TiDB Deployments: The documentation now explicitly states that TiDB Self-Managed and TiDB Cloud Dedicated deployments do not support FULLTEXT syntax and indexes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MySQL compatibility documentation to clarify the support status of FULLTEXT syntax and indexes across different TiDB offerings. The change is accurate and helpful. I have provided one minor suggestion to improve the wording for clarity and conciseness, in line with the repository's style guide.


>**Note:**
>
> Currently, only {{{ .starter }} and {{{ .essential }}} clusters in certain AWS regions support [`FULLTEXT` syntax and indexes](/tidb-cloud/vector-search-full-text-search-sql.md). TiDB Self-Managed and TiDB Cloud Dedicated do not support `FULLTEXT` syntax and indexes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For better readability and to avoid repetition, consider rephrasing this sentence. The suggestion combines the two sentences into one and avoids repeating the phrase 'FULLTEXT syntax and indexes'.1

Suggested change
> Currently, only {{{ .starter }} and {{{ .essential }}} clusters in certain AWS regions support [`FULLTEXT` syntax and indexes](/tidb-cloud/vector-search-full-text-search-sql.md). TiDB Self-Managed and TiDB Cloud Dedicated do not support `FULLTEXT` syntax and indexes.
> Currently, [`FULLTEXT` syntax and indexes](/tidb-cloud/vector-search-full-text-search-sql.md) are only supported on {{{ .starter }}} and {{{ .essential }}} clusters in certain AWS regions, and are not supported in TiDB Self-Managed and TiDB Cloud Dedicated.

Style Guide References

Footnotes

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2025
@qiancai qiancai added translation/no-need No need to translate this PR. needs-cherry-pick-master Should cherry pick this PR to master branch. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Oct 24, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 24, 2025
@qiancai qiancai self-assigned this Oct 24, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 24, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 27, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-24 04:11:40.891458959 +0000 UTC m=+1017806.968711519: ☑️ agreed by dveeden.
  • 2025-10-27 06:46:32.121469627 +0000 UTC m=+1286298.198722187: ☑️ agreed by breezewish.

@hfxsd
Copy link
Collaborator

hfxsd commented Oct 27, 2025

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Oct 27, 2025
@dveeden
Copy link
Contributor

dveeden commented Oct 27, 2025

@hfxsd what about the HTTP 400's that are reported by tidb-check?

@qiancai
Copy link
Collaborator Author

qiancai commented Oct 28, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd, qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 55f24d8 into pingcap:release-8.5 Oct 28, 2025
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch master: #21978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants