-
Notifications
You must be signed in to change notification settings - Fork 706
cloud: update the support info of fulltext syntax #21967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud: update the support info of fulltext syntax #21967
Conversation
Summary of ChangesHello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the TiDB documentation by providing precise details on the availability of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the MySQL compatibility documentation to clarify the support status of FULLTEXT syntax and indexes across different TiDB offerings. The change is accurate and helpful. I have provided one minor suggestion to improve the wording for clarity and conciseness, in line with the repository's style guide.
mysql-compatibility.md
Outdated
|
|
||
| >**Note:** | ||
| > | ||
| > Currently, only {{{ .starter }} and {{{ .essential }}} clusters in certain AWS regions support [`FULLTEXT` syntax and indexes](/tidb-cloud/vector-search-full-text-search-sql.md). TiDB Self-Managed and TiDB Cloud Dedicated do not support `FULLTEXT` syntax and indexes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to avoid repetition, consider rephrasing this sentence. The suggestion combines the two sentences into one and avoids repeating the phrase 'FULLTEXT syntax and indexes'.1
| > Currently, only {{{ .starter }} and {{{ .essential }}} clusters in certain AWS regions support [`FULLTEXT` syntax and indexes](/tidb-cloud/vector-search-full-text-search-sql.md). TiDB Self-Managed and TiDB Cloud Dedicated do not support `FULLTEXT` syntax and indexes. | |
| > Currently, [`FULLTEXT` syntax and indexes](/tidb-cloud/vector-search-full-text-search-sql.md) are only supported on {{{ .starter }}} and {{{ .essential }}} clusters in certain AWS regions, and are not supported in TiDB Self-Managed and TiDB Cloud Dedicated. |
Style Guide References
Footnotes
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
@hfxsd what about the HTTP 400's that are reported by tidb-check? |
Co-authored-by: xixirangrang <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd, qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add notes to clarify the availability of FULLTEXT syntax and indexes for different product options.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?