-
Notifications
You must be signed in to change notification settings - Fork 708
improve list in the subquery optimization #22057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @hawkingrei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation for subquery optimization by expanding the list of recognized subquery patterns. Specifically, it introduces the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve the list of subquery situations in the documentation. The change adds a case for ALL subqueries and reorders the list slightly. My review focuses on further improving this list for clarity, consistency, and completeness. I've suggested a reorganization that groups related items, corrects a minor typo, and uses more general terms for better readability.
| - `... </=/!=/>/ ALL (SELECT ... FROM ...)` | ||
| - `NOT IN (SELECT ... FROM ...)` | ||
| - `NOT EXISTS (SELECT ... FROM ...)` | ||
| - `IN (SELECT ... FROM ..)` | ||
| - `NOT EXISTS (SELECT ... FROM ...)` | ||
| - `EXISTS (SELECT ... FROM ...)` | ||
| - `... >/>=/</<=/=/!= (SELECT ... FROM ...)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and consistency, I suggest reorganizing and clarifying this list.
- The current list has a minor typo (
..instead of...). - The order can be improved by grouping related operators.
- For quantified comparisons, we can generalize the operators and include
ANYandSOMEfor completeness. - Using
comparison_operatoris cleaner than listing out individual symbols.
Here is a suggested improvement:
| - `... </=/!=/>/ ALL (SELECT ... FROM ...)` | |
| - `NOT IN (SELECT ... FROM ...)` | |
| - `NOT EXISTS (SELECT ... FROM ...)` | |
| - `IN (SELECT ... FROM ..)` | |
| - `NOT EXISTS (SELECT ... FROM ...)` | |
| - `EXISTS (SELECT ... FROM ...)` | |
| - `... >/>=/</<=/=/!= (SELECT ... FROM ...)` | |
| - `IN (SELECT ... FROM ...)` | |
| - `NOT IN (SELECT ... FROM ...)` | |
| - `EXISTS (SELECT ... FROM ...)` | |
| - `NOT EXISTS (SELECT ... FROM ...)` | |
| - `... comparison_operator [ANY | ALL | SOME] (SELECT ... FROM ...)` | |
| - `... comparison_operator (SELECT ... FROM ...)` |
First-time contributors' checklist
What is changed, added or deleted? (Required)
ref #21869
Improve the sample list here so that customers don't mistakenly think content is missing.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?