-
Notifications
You must be signed in to change notification settings - Fork 708
sync-diff-inspector: clarify data type support and improve collation guidance #22165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @alastori, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the sync-diff-inspector documentation by clarifying data type support and providing detailed guidance on handling collations to prevent false positives. The changes are accurate, well-researched, and add a lot of value for users. I've provided a couple of minor suggestions to enhance readability and ensure consistency with the documentation style guide. Overall, this is an excellent contribution.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
PTAL @Frank945946 @joechenrh |
|
@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joechenrh: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What is changed, added or deleted? (Required)
This PR updates the sync-diff-inspector documentation to fix misleading language about data type support and add empirically-validated guidance to prevent false-positive validation failures.
Key changes:
Clarified data type support: Added explicit documentation that JSON, BLOB/VARBINARY, and BIT types are supported, correcting misleading comments suggesting they are not.
Improved collation guidance: Enhanced the collation warning with specific examples (MySQL 8.0
utf8mb4_0900_ai_civs TiDButf8mb4_bin) and actionable recommendations to avoid false positives.Documented known false-positive patterns: Added list of scenarios that produce false differences (collation mismatches in VARCHAR/TEXT/JSON, auto-populated TIMESTAMP columns).
Added TIMESTAMP handling guidance: Provided concrete approaches for handling auto-populated timestamp columns during validation.
All changes are based on comprehensive empirical validation testing using MySQL 8.0 → TiDB v8.5.4.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?