-
Notifications
You must be signed in to change notification settings - Fork 708
v8.5.5: br: add compatibility between log backup and PITR (#20485) #22168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -498,3 +498,25 @@ tiup br restore point --pd="${PD_IP}:2379" | |||||
| --master-key-crypter-method aes128-ctr | ||||||
| --master-key "local:///path/to/master.key" | ||||||
| ``` | ||||||
|
|
||||||
| ### Compatibility between ongoing log backup and snapshot restore | ||||||
|
|
||||||
| Starting from v9.0.0, when a log backup task is running, if all of the following conditions are met, you can still perform snapshot restore (`br restore [full|database|table]`) and allow the restored data to be properly recorded by the ongoing log backup (hereinafter referred to as "log backup"): | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| - The node performing backup and restore operations has the following necessary permissions: | ||||||
qiancai marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| - Read access to the external storage containing the backup source, for snapshot restore | ||||||
| - Write access to the target external storage used by the log backup | ||||||
| - The target external storage for the log backup is Amazon S3 (`s3://`), Google Cloud Storage (`gcs://`), or Azure Blob Storage (`azblob://`). | ||||||
| - The data to be restored uses the same type of external storage as the target storage for the log backup. | ||||||
| - Neither the data to be restored nor the log backup has enabled local encryption. For details, see [log backup encryption](#encrypt-the-log-backup-data) and [snapshot backup encryption](/br/br-snapshot-manual.md#encrypt-the-backup-data). | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a minor grammatical error here. When using 'Neither...nor' with two distinct subjects, a plural verb is often preferred for clarity.
Suggested change
|
||||||
|
|
||||||
| If any of the above conditions are not met, or if you need to perform a point-in-time recovery, while a log backup task is running, BR refuses to proceed with the data recovery. In this case, you can complete the recovery by following these steps: | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sentence can be rephrased for better clarity. Also, using 'restore' instead of 'recovery' would be more consistent with the rest of the document.
Suggested change
|
||||||
|
|
||||||
| 1. [Stop the log backup task](#stop-a-log-backup-task). | ||||||
| 2. Perform the data restore. | ||||||
| 3. After the restore is complete, perform a new snapshot backup. | ||||||
| 4. [Restart the log backup task](#restart-a-log-backup-task). | ||||||
|
|
||||||
| > **Note:** | ||||||
| > | ||||||
| > When restoring a log backup that contains records of snapshot (full) restore data, you must use BR v9.0.0 or later. Otherwise, restoring the recorded full restore data might fail. | ||||||
qiancai marked this conversation as resolved.
Show resolved
Hide resolved
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
Uh oh!
There was an error while loading. Please reload this page.