-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix pitr meta kv fail to parse in during table filter code refactor (#60023) #60039
br: fix pitr meta kv fail to parse in during table filter code refactor (#60023) #60039
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-9.0-beta.1 #60039 +/- ##
==========================================================
+ Coverage 73.0799% 74.7061% +1.6262%
==========================================================
Files 1702 1718 +16
Lines 470132 470276 +144
==========================================================
+ Hits 343572 351325 +7753
+ Misses 105385 97120 -8265
- Partials 21175 21831 +656
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/hold |
/unhold |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, Tristan1900 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
This is an automated cherry-pick of #60023
What problem does this PR solve?
Issue Number: close #60024, close #57613
Problem Summary:
The pitr restore meta kv parsing phase has some issue regarding to writeCF value, and the pitr restore could fail
What changed and how does it work?
this PR made it exact same as the rewrite_meta_kv logic to avoid the parsing failure found in e2e test.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.