Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix pitr meta kv fail to parse in during table filter code refactor (#60023) #60039

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #60023

What problem does this PR solve?

Issue Number: close #60024, close #57613

Problem Summary:

The pitr restore meta kv parsing phase has some issue regarding to writeCF value, and the pitr restore could fail

What changed and how does it work?

this PR made it exact same as the rewrite_meta_kv logic to avoid the parsing failure found in e2e test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7061%. Comparing base (cbda2c9) to head (4730322).
Report is 2 commits behind head on release-9.0-beta.1.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           release-9.0-beta.1     #60039        +/-   ##
==========================================================
+ Coverage             73.0799%   74.7061%   +1.6262%     
==========================================================
  Files                    1702       1718        +16     
  Lines                  470132     470276       +144     
==========================================================
+ Hits                   343572     351325      +7753     
+ Misses                 105385      97120      -8265     
- Partials                21175      21831       +656     
Flag Coverage Δ
integration 46.3272% <100.0000%> (?)
unit 72.3701% <0.0000%> (+0.0801%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.3010% <100.0000%> (+15.0839%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tristan1900
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2025
@Tristan1900
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 12, 2025
@Tristan1900
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 17, 2025
@Tristan1900
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025
Copy link

ti-chi-bot bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, Tristan1900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-17 01:36:04.140346628 +0000 UTC m=+233057.824582724: ☑️ agreed by Leavrth.
  • 2025-03-17 14:39:38.22611421 +0000 UTC m=+280071.910350306: ☑️ agreed by Tristan1900.

@Tristan1900
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 2d3ecc0 into pingcap:release-9.0-beta.1 Mar 17, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants