restore: disable pd follower handle #60116

3pointer · 2025-03-17T08:58:03Z

What problem does this PR solve?

Issue Number: close #60105
ref #60085

Problem Summary:
A scan region issue was identified in pingcap/tidb#60085

What changed and how does it work?

Temporarily disabled the PD follower handle to ensure that region scanning functions correctly when restoring from a checkpoint.
Fixed a panic issue caused by a missing nil check during checkpoint removal.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2025-03-17T08:58:06Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2025-03-17T08:58:20Z

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

3pointer · 2025-03-17T09:27:08Z

/test pull-integration-br-test

ti-chi-bot · 2025-03-17T09:27:11Z

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-scan-deps

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_br_integration_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

In response to this:

/test pull-integration-br-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-17T09:27:33Z

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-integration-br-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-17T09:27:34Z

@ti-chi-bot[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-scan-deps
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test pull-integration-br-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-03-17T09:27:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~br/OWNERS~~ [Leavrth,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-03-17T09:27:46Z

[LGTM Timeline notifier]

Timeline:

2025-03-17 09:12:24.639414725 +0000 UTC m=+260438.323650821: ☑️ agreed by Leavrth.
2025-03-17 09:27:45.422901293 +0000 UTC m=+261359.107137388: ☑️ agreed by YuJuncen.

codecov · 2025-03-17T09:48:44Z

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.7057%. Comparing base (388c36b) to head (1305888).
Report is 1 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #60116        +/-   ##
================================================
+ Coverage   73.1410%   74.7057%   +1.5647%     
================================================
  Files          1707       1723        +16     
  Lines        471608     471704        +96     
================================================
+ Hits         344939     352390      +7451     
+ Misses       105472      97414      -8058     
- Partials      21197      21900       +703

Flag	Coverage Δ
integration	`46.1641% <40.0000%> (?)`
unit	`72.3479% <0.0000%> (-0.0098%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`62.2874% <40.0000%> (+15.0665%)`	⬆️

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

3pointer · 2025-03-17T09:55:45Z

/test check-dev2

tiprow · 2025-03-17T09:56:07Z

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

3pointer · 2025-03-17T10:47:40Z

/test check-dev2

3pointer · 2025-03-17T10:47:58Z

/test unit-test

tiprow · 2025-03-17T10:48:02Z

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-17T10:48:21Z

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

3pointer · 2025-03-17T10:48:28Z

/ok-to-test

3pointer · 2025-03-17T12:10:10Z

/test unit-test

tiprow · 2025-03-17T12:10:34Z

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

3pointer · 2025-03-17T14:05:19Z

/retest

ti-chi-bot · 2025-03-17T14:30:19Z

In response to a cherrypick label: new pull request created to branch release-9.0-beta.1: #60128.

restore: disable pd follower handle

9e9b723

3pointer force-pushed the disable_pd_follower_handle branch from fc9ee0e to 9e9b723 Compare March 17, 2025 09:01

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Mar 17, 2025

3pointer marked this pull request as ready for review March 17, 2025 09:11

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2025

Leavrth approved these changes Mar 17, 2025

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025

fix build

0685a06

YuJuncen approved these changes Mar 17, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 17, 2025

Merge branch 'master' into disable_pd_follower_handle

1305888

3pointer added the needs-cherry-pick-release-9.0-beta.1 label Mar 17, 2025

ti-chi-bot bot merged commit def3d2d into pingcap:master Mar 17, 2025
29 checks passed

ti-chi-bot mentioned this pull request Mar 17, 2025

restore: disable pd follower handle (#60116) #60128

Open

13 tasks

Leavrth mentioned this pull request Mar 19, 2025

br: skip update follower handle region if no need to scan regions #60034

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

restore: disable pd follower handle #60116

restore: disable pd follower handle #60116

3pointer commented Mar 17, 2025 •

edited

Loading

ti-chi-bot bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

3pointer commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

codecov bot commented Mar 17, 2025 •

edited

Loading

3pointer commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

3pointer commented Mar 17, 2025

3pointer commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

3pointer commented Mar 17, 2025

3pointer commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

3pointer commented Mar 17, 2025

ti-chi-bot commented Mar 17, 2025

restore: disable pd follower handle #60116

restore: disable pd follower handle #60116

Conversation

3pointer commented Mar 17, 2025 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

3pointer commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

[LGTM Timeline notifier]

codecov bot commented Mar 17, 2025 • edited Loading

Codecov Report

3pointer commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

3pointer commented Mar 17, 2025

3pointer commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

3pointer commented Mar 17, 2025

3pointer commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

3pointer commented Mar 17, 2025

ti-chi-bot commented Mar 17, 2025

3pointer commented Mar 17, 2025 •

edited

Loading

codecov bot commented Mar 17, 2025 •

edited

Loading