Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objstore: retry on "server sent GOAWAY" http2 error #60144

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Mar 18, 2025

What problem does this PR solve?

Issue Number: close #60143

Problem Summary:

What changed and how does it work?

Add "server sent GOAWAY" to retry error list, since gcp support recommends to retry on this error.

And see https://stackoverflow.com/questions/45209168/http2-server-sent-goaway-and-closed-the-connection-laststreamid-1999 for details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2025
Copy link

tiprow bot commented Mar 18, 2025

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8044%. Comparing base (bf21e59) to head (893fad6).
Report is 59 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60144        +/-   ##
================================================
+ Coverage   73.0689%   74.8044%   +1.7355%     
================================================
  Files          1701       1753        +52     
  Lines        469836     489141     +19305     
================================================
+ Hits         343304     365899     +22595     
+ Misses       105363     100559      -4804     
- Partials      21169      22683      +1514     
Flag Coverage Δ
integration 48.8415% <100.0000%> (?)
unit 72.3474% <100.0000%> (+0.0597%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.4656% <100.0000%> (+13.3836%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-triage-completed labels Mar 18, 2025
Copy link

ti-chi-bot bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 18, 2025
Copy link

ti-chi-bot bot commented Mar 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-18 07:58:58.874828773 +0000 UTC m=+342432.559064865: ☑️ agreed by lance6716.
  • 2025-03-18 08:23:22.200015065 +0000 UTC m=+343895.884251160: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit ddfd52a into pingcap:master Mar 18, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import task should retry on GCS error server sent GOAWAY
3 participants