-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: pitr sort tables before creating #60219
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60219 +/- ##
================================================
+ Coverage 73.1385% 74.6777% +1.5391%
================================================
Files 1707 1724 +17
Lines 471602 477082 +5480
================================================
+ Hits 344923 356274 +11351
+ Misses 105483 98662 -6821
- Partials 21196 22146 +950
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
require.Len(t, sorted, 7, "Should have 7 tables after sorting") | ||
|
||
expectedSchemaIDs := []int64{1, 1, 2, 2, 3, 3, 6} | ||
actualSchemaIDs := make([]int64, 7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add expectedTablesIDs
and actualTableIDs
.
Signed-off-by: Wenqi Mou <[email protected]>
What problem does this PR solve?
Issue Number: close #60218
Problem Summary:
What changed and how does it work?
sort tables by schema id before creating
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.