-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: try to make dependencies between libraries more clear #10018
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9ede5a3
to
67515cb
Compare
/hold |
/retest |
Signed-off-by: Lloyd-Pottiger <[email protected]>
3c54d7f
to
2a58690
Compare
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #6233
Problem Summary:
What is changed and how it works?
Before, if we need to add a executable binary (which includes
Storages/DeltaMerge/File/DMFile.h
), we need to link a lot of libraries:This is because now the dependencies between libraries is quite complex. This PR try to make dependencies between libraries more clear.
After this PR, we only need:
Check List
Tests
Side effects
Documentation
Release note