-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): 📦 version packages #1152
Conversation
c53c7dd
to
9108369
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThis pull request introduces an Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant C as Upload Component
participant O as Option Handler
participant X as XHR Upload Process
U->>C: Initiate file upload
C->>O: Retrieve uploadProgressGranularity setting (all/fine/coarse)
O-->>C: Return granularity value
C->>X: Begin file upload with specified granularity
X->>C: Emit progress events at chosen frequency
C->>U: Display upload progress
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
4f34173
to
008e953
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/svelte/CHANGELOG.md (1)
5-19
: New Feature Addition:uploadProgressGranularity
OptionThe changelog entry clearly describes the addition of the
uploadProgressGranularity
option, including its allowed values and behavior:
all
– forwards every event from the XHR upload.fine
– forwards events for every 1% progress.coarse
(default) – forwards events for every 10% progress.A minor suggestion: consider using “triggered” instead of “fired at” to improve clarity.
packages/shared/CHANGELOG.md (1)
3-19
: New Version Entry for 7.1.7 withuploadProgressGranularity
This changelog entry clearly documents the new feature by listing the available options (
all
,fine
, andcoarse
) and explaining what each does. Consider rephrasing the repeated phrase “fired at” (for example, “triggered” or “emitted”) to improve clarity.packages/solid/CHANGELOG.md (2)
5-12
: Minor Changes Section – New Option DocumentationThe new minor changes block properly documents the addition of the
uploadProgressGranularity
option (introduced via #1151). The inclusion of the commit link and thanks to the contributor add transparency. One minor suggestion is to consider rephrasing “fired at” (line 11) for improved clarity (e.g. “triggered” or “emitted”).
13-14
: Clarification on Option UsageThe description explaining that
uploadProgressGranularity
accepts valuesall
,fine
, orcoarse
is concise. For increased grammatical clarity, consider rewording the sentence. For example, “You can now setuploadProgressGranularity
toall
,fine
, orcoarse
to determine the frequency at which progress events are emitted.”packages/vue/CHANGELOG.md (1)
7-19
: Detailing the New Feature
This block provides details on the newly addeduploadProgressGranularity
option, explaining that users can set it toall
,fine
, orcoarse
. The explanation and bullet-point list are clear and succinct. A minor suggestion: consider rephrasing “fired at” (e.g., “triggered” or “emitted”) to improve clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (41)
.changeset/fair-tomatoes-jog.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(1 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(1 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(1 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(1 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(1 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(1 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(1 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(1 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/fair-tomatoes-jog.md
✅ Files skipped from review due to trivial changes (29)
- packages/nuxt/package.json
- packages/shared/package.json
- packages/svelte/package.json
- packages/vue/package.json
- packages/react/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/solid/package.json
- examples/backend-adapters/client-vue/package.json
- examples/backend-adapters/client-react/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-solidstart/package.json
- examples/profile-picture/package.json
- examples/with-drizzle-appdir/package.json
- examples/with-novel/package.json
- packages/expo/CHANGELOG.md
- examples/backend-adapters/server/package.json
- examples/minimal-astro-react/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-expo/package.json
- packages/nuxt/CHANGELOG.md
- examples/with-clerk-remix/package.json
- examples/minimal-tanstack-start/package.json
- examples/with-clerk-pagesdir/package.json
- packages/uploadthing/package.json
- examples/with-clerk-appdir/package.json
- examples/with-serveractions/package.json
- packages/expo/package.json
- examples/backend-adapters/package.json
🔇 Additional comments (25)
packages/svelte/CHANGELOG.md (2)
3-4
: Version Bump Header for 7.3.0The new version header "## 7.3.0" is clear and effectively highlights the latest release.
20-25
: Dependency Update: @uploadthing/shared Version BumpThe patch changes section accurately documents the dependency update to
@uploadthing/[email protected]
with an appropriate commit reference. This ensures consistency across the packages.examples/with-react-image-crop/package.json (2)
12-13
: Approved: Dependency Version Update for @uploadthing/react
The version change to"7.3.0"
reflects the release that introduces the newuploadProgressGranularity
option. This update is consistent with the overall package upgrade.
17-17
: Approved: Dependency Version Update for uploadthing
The version has been correctly updated to"7.5.2"
, ensuring consistency with the minor version bump across the ecosystem.examples/minimal-appdir/package.json (2)
12-13
: Approved: Dependency Version Update for @uploadthing/react
The dependency update to"7.3.0"
is in line with the release changes and brings in the new progress granularity feature.
16-16
: Approved: Dependency Version Update for uploadthing
Updating to"7.5.2"
maintains consistency with the overall upgrade strategy across all examples.examples/with-tailwindcss/package.json (2)
12-13
: Approved: Dependency Version Update for @uploadthing/react
The version has been correctly bumped to"7.3.0"
, reflecting the introduction of the new upload progress option.
16-16
: Approved: Dependency Version Update for uploadthing
The updated version"7.5.2"
is consistent with other package updates in this PR.examples/minimal-sveltekit/package.json (2)
17-17
: Approved: Dependency Version Update for @uploadthing/svelte
Changing to"7.3.0"
correctly aligns with the new feature rollout and ensures compatibility with the updated ecosystem.
18-18
: Approved: Dependency Version Update for uploadthing
The"7.5.2"
version update here is in line with changes across other examples, ensuring consistency.examples/with-clerk-react-router/package.json (2)
16-16
: Approved: Dependency Version Update for @uploadthing/react
The upgrade to"7.3.0"
reflects the necessary update for utilizing the newuploadProgressGranularity
option.
22-22
: Approved: Dependency Version Update for uploadthing
The bump to"7.5.2"
is applied uniformly and aligns well with the overall dependency update strategy.packages/react/CHANGELOG.md (2)
3-19
: New Version 7.3.0 Release Entry for @uploadthing/reactThe entry effectively introduces the new
uploadProgressGranularity
option. It clearly explains the available settings and provides practical guidance for users.
20-25
: Dependency Update to @uploadthing/[email protected]The dependency bump is correctly applied and aligns with the new shared functionality. This update ensures consistency across packages.
packages/uploadthing/CHANGELOG.md (5)
3-4
: Version Bump Verification:
The release note header for version 7.5.2 is clearly marked and follows the expected changelog format. This helps users immediately identify the new release.
5-6
: Section Heading – Patch Changes:
The heading "### Patch Changes" is appropriately used here and sets up the context for the updates that follow.
7-12
: New Feature Entry foruploadProgressGranularity
:
The changelog entry documents the addition of theuploadProgressGranularity
option along with the commit reference and acknowledgment. It concisely describes the feature addition. One minor suggestion is to verify that the default behavior (later described ascoarse
) is highlighted so users have immediate clarity if they do not specify a value.
13-19
: Detailed Explanation of Granularity Options:
The breakdown of the available options—all
,fine
, andcoarse
—is both clear and informative. This explanation provides a solid guide on how progress events will be fired based on the chosen granularity.
20-23
: Dependency Update Details:
The dependency update block clearly indicates that@uploadthing/shared
has been updated to version 7.1.7 with its corresponding commit reference. It would be good to double-check that this dependency update is in sync across all related packages if applicable.packages/solid/CHANGELOG.md (3)
3-4
: Clear Version HeaderThe header
## 7.3.0
clearly indicates the new release version and follows the changelog’s existing style. This helps users quickly locate the most recent changes.
16-18
: Bullet Points for Progress EventsThe bullet points effectively differentiate the behaviors of the three settings:
all
– forwards every event from the XHR upload,fine
– forwards events for every 1% of progress, andcoarse
– (default) forwards events for every 10% of progress.This clear distinction minimizes confusion about the feature’s functionality.
20-24
: Patch Changes – Dependency UpdateThe patch changes section documents the update to the
@uploadthing/shared
dependency (upgraded to version 7.1.7) with a commit reference. The dependency update is clearly noted, ensuring consistency with similar changes in other packages.packages/vue/CHANGELOG.md (3)
3-4
: New Release Header Added
The section header for version 7.3.0 is clearly introduced. This correctly marks the new release entry for the @uploadthing/vue package.
20-25
: Dependency Update Documentation
The Patch Changes section clearly documents the dependency update for@uploadthing/shared
to version 7.1.7 with the associated commit reference. This is consistent with the changelog style of previous versions.
26-312
: Historical Release Notes Consistency
The remainder of the file contains historical records for earlier releases (versions 7.2.0 down to 6.5.0). These entries are well maintained and consistent with established formatting. No issues noted in these sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/svelte/CHANGELOG.md (1)
7-19
: Documentation of NewuploadProgressGranularity
FeatureThis section effectively explains the new
uploadProgressGranularity
option, including its available settings (all
,fine
, andcoarse
). The commit reference, acknowledgment, and detailed description ensure transparency about the change.Suggestion: Consider rephrasing "fired at" to "emitted" to improve clarity. For example, update:
- feat: add `uploadProgressGranularity` option to control how granular progress events are fired at + feat: add `uploadProgressGranularity` option to control the granularity of emitted progress eventsThis minor wording tweak can enhance readability and consistency with industry terminology.
packages/vue/CHANGELOG.md (1)
5-19
: Clarify theuploadProgressGranularity
Option Description
The changelog clearly documents the addition of theuploadProgressGranularity
option and its available settings (all
,fine
, andcoarse
). However, the phrasing at lines 10–11 (“...fired at”) can be a bit ambiguous. Consider rephrasing it to something like “...emitted during the upload process” or “...triggered at the specified intervals” for improved clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (41)
.changeset/fair-tomatoes-jog.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(1 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(1 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(1 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(1 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(1 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(1 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(1 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(1 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/fair-tomatoes-jog.md
🚧 Files skipped from review as they are similar to previous changes (38)
- packages/shared/package.json
- packages/vue/package.json
- packages/expo/package.json
- packages/solid/package.json
- packages/uploadthing/package.json
- packages/svelte/package.json
- packages/react/package.json
- examples/with-serveractions/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-clerk-pagesdir/package.json
- examples/profile-picture/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-clerk-appdir/package.json
- packages/nuxt/package.json
- examples/minimal-expo/package.json
- examples/with-clerk-react-router/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-astro-react/package.json
- examples/backend-adapters/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-pagedir/package.json
- packages/expo/CHANGELOG.md
- examples/with-tailwindcss/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- examples/minimal-appdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/minimal-sveltekit/package.json
- packages/nuxt/CHANGELOG.md
- examples/backend-adapters/client-react/package.json
- packages/uploadthing/CHANGELOG.md
- examples/minimal-solidstart/package.json
- packages/shared/CHANGELOG.md
- packages/react/CHANGELOG.md
- examples/with-drizzle-appdir/package.json
- packages/solid/CHANGELOG.md
- examples/backend-adapters/server/package.json
🔇 Additional comments (4)
packages/svelte/CHANGELOG.md (2)
3-4
: Version Header for 7.3.0 is ClearThe new "## 7.3.0" header is clearly delineated, indicating a major milestone for the package release.
22-24
: Dependency Update Noted SuccessfullyThe changelog correctly documents the update of
@uploadthing/shared
to version 7.1.7 under the patch changes. This explicit tracking of dependency versions is important for maintainability and compatibility.packages/vue/CHANGELOG.md (2)
3-4
: New Version Header is Correctly Formatted
The new version header"## 7.3.0"
is clear and follows the established markdown convention. This correctly signals the introduction of the new release.
22-25
: Dependency Update Section Verified
The patch changes section properly lists the dependency update to@uploadthing/[email protected]
. This aligns with the PR objectives and ensures consistency across related packages.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@uploadthing/[email protected]
Minor Changes
#1151
67c3b1c
Thanks @juliusmarminge! - feat: add
uploadProgressGranularity
option to control how granular progress events arefired at
You can now set
uploadProgressGranularity
toall
,fine
, orcoarse
tocontrol how granular progress events are fired at.
all
will forward every event from the XHR uploadfine
will forward events for every 1% of progresscoarse
(default) will forward events for every 10% of progressPatch Changes
[
a1e13b5
]:@uploadthing/[email protected]
Minor Changes
#1151
67c3b1c
Thanks @juliusmarminge! - feat: add
uploadProgressGranularity
option to control how granular progress events arefired at
You can now set
uploadProgressGranularity
toall
,fine
, orcoarse
tocontrol how granular progress events are fired at.
all
will forward every event from the XHR uploadfine
will forward events for every 1% of progresscoarse
(default) will forward events for every 10% of progressPatch Changes
[
a1e13b5
]:@uploadthing/[email protected]
Minor Changes
#1151
67c3b1c
Thanks @juliusmarminge! - feat: add
uploadProgressGranularity
option to control how granular progress events arefired at
You can now set
uploadProgressGranularity
toall
,fine
, orcoarse
tocontrol how granular progress events are fired at.
all
will forward every event from the XHR uploadfine
will forward events for every 1% of progresscoarse
(default) will forward events for every 10% of progressPatch Changes
[
a1e13b5
]:@uploadthing/[email protected]
Minor Changes
#1151
67c3b1c
Thanks @juliusmarminge! - feat: add
uploadProgressGranularity
option to control how granular progress events arefired at
You can now set
uploadProgressGranularity
toall
,fine
, orcoarse
tocontrol how granular progress events are fired at.
all
will forward every event from the XHR uploadfine
will forward events for every 1% of progresscoarse
(default) will forward events for every 10% of progressPatch Changes
[
a1e13b5
]:@uploadthing/[email protected]
Patch Changes
[
67c3b1c
,a1e13b5
]:@uploadthing/[email protected]
Patch Changes
[
67c3b1c
]:@uploadthing/[email protected]
Patch Changes
a1e13b5
Thanks @juliusmarminge! - This release
just contains helper exports for the new
uploadProgressGranularity
featurein the frontend library adapters
[email protected]
Patch Changes
a1e13b5
Thanks @juliusmarminge! - This release
just contains helper exports for the new
uploadProgressGranularity
featurein the frontend library adapters
[
a1e13b5
]:Summary by CodeRabbit
New Features
Chores