Feat/questions optional #687
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tribute in User model
|
@MrPunyapal do you think I need to do anything else? If so please let me know. |
|
Tests are missing And also a validation in a questions/create component |
|
I would call it |
MrPunyapal
requested changes
Oct 5, 2024
…ut for prefers_questions
…at profile or prefer questions
…y.com into feat/questions-optional
…clean up code formatting
…uestion reception
…tests accordingly
|
Things I changed
|
MrPunyapal
reviewed
Oct 28, 2024
resources/views/profile/partials/update-profile-information-form.blade.php
Show resolved
Hide resolved
MrPunyapal
reviewed
Oct 28, 2024
| name="prefers_questions" | ||
| class="mt-1 block w-full" | ||
| class="mt-1 block w-full" | ||
| :options="[true => __('People can ask me questions'), false => __('I do not want to receive questions')]" |
There was a problem hiding this comment.
keep it simple "yes" and "no"
MrPunyapal
reviewed
Oct 28, 2024
| @@ -206,6 +205,13 @@ public function store(Request $request): void | |||
|
|
|||
| $user = type($request->user())->as(User::class); | |||
|
|
|||
| $toUser = User::findOrFail($this->toId); | |||
|
|
|||
| if (!$toUser->prefers_questions) { | |||
MrPunyapal
reviewed
Oct 28, 2024
| $toUser = User::findOrFail($this->toId); | ||
|
|
||
| if (!$toUser->prefers_questions) { | ||
| $this->addError('content', __('This user does not accept questions.')); |
There was a problem hiding this comment.
Better we refresh the page with a notification so it resets the page and removes the component from the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #630.
"Currently, the questions feature is not optional, but some people, like me, may not want to use it, since Pinkary's initial proposal - I think, was for bio links."