Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tests): fix caching of PHP dependencies #760

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ferencik-f
Copy link

What:

  • Bug Fix
  • New Feature

Description:

This PR resolves an issue with caching PHP dependencies in CI.

Before - cache error:

image

After - cache created:

Screenshot 2025-01-19 at 10 32 34

Next run - cache restored and install skipped:

Screenshot 2025-01-19 at 10 29 54

CamKem
CamKem previously approved these changes Feb 17, 2025
Copy link
Collaborator

@CamKem CamKem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try and keep the concerns in PR to one thing, for now, because its not affecting logic, i'll approve this, however next time seperate concerns onto seperate PR's.

@CamKem CamKem dismissed their stale review February 18, 2025 00:06

further review highlighted changes required.

@@ -0,0 +1,16 @@
<!--
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file from the PR, as I just noticed you have another PR addressing the introduction of this template in #759 - that way we keep the PR to only one concern of changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't notice. Done.

@ferencik-f ferencik-f requested a review from CamKem February 18, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants