Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor home menu #762

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor home menu #762

wants to merge 4 commits into from

Conversation

Rattone
Copy link
Contributor

@Rattone Rattone commented Feb 5, 2025

No description provided.

CamKem
CamKem approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@CamKem CamKem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure, looks good!

For a future PR, could go even further by making the whole anchor tag a (or whatever appropriate name) component.

@Rattone
Copy link
Contributor Author

Rattone commented Feb 18, 2025

For a future PR, could go even further by making the whole anchor tag a (or whatever appropriate name) component.

Yes, the intent was to give a first cleaning.
Next I could create a component class for the menu structure and a menu-link component for the individual items

@MrPunyapal
Copy link
Collaborator

Next I could create a component class for the menu structure and a menu-link component for the individual items
@Rattone, doing it in the same PR will be the best!

@Rattone Rattone changed the title Refactor home menu to array Refactor home menu Feb 18, 2025
@Rattone
Copy link
Contributor Author

Rattone commented Feb 18, 2025

@CamKem @MrPunyapal could it be okay?

@MrPunyapal MrPunyapal requested a review from CamKem February 19, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamKem CamKem Awaiting requested review from CamKem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rattone @MrPunyapal @CamKem