[WIP] Feat: move to cloud #765
Conversation
… and questions tables
…estion, and questions tables
…atabase compatibility
… display order and performance
…proved performance
…for improved compatibility
…gs assertions in tests
| $table->rawIndex('name collate nocase', 'name_collate_nocase'); | ||
| }else{ | ||
| // mysql | ||
| $table->index('name', 'name_case_insensitive', 'BTREE'); // not working |
There was a problem hiding this comment.
@steven-fox can you help here?
There was a problem hiding this comment.
@MrPunyapal Hey man. Here's my understanding:
In mysql, collation is controlled on a per-column basis. Therefore, if the collation on the name column of our hashtags table is case insensitive (for example, a collation of utf8mb4_unicode_ci [that _ci is "case-insensitive" instead of _cs for "case-sensitive"]), then you should only need to specify a standard index on the column and you'll be good to go. The custom index was needed for sqlite to force an index that isn't case sensitive.
Try doing a normal $table->index('name'); and then run the tests (or manually check) with a mysql db.
There was a problem hiding this comment.
I already tried that
There was a problem hiding this comment.
Sorry - I had to re-read the error you sent me of the failing test again. Based on that, it looks like the ACTUAL problem is that a unique constraint violation is occurring when attempting to insert records of foo and Foo, which makes sense, as the column probably has a case insensitive collation so we'd need to manually specify a case sensitive unique index.
Here's what I'd do:
- Use a case insensitive column definition for
hashtags.name(probably the default). Something likeutfmb4_0900_ai_ciwould be a good choice. Again, probably doesn't have to be specified manually as it's likely the default across the database, but would check for the production db to be sure. - Apply a normal index on the
namecolumn (so the index will be case insensitive) for our hashtag lookups. Mainly used in\App\Services\Autocomplete\Types\Hashtagsand\App\Queries\Feeds\RecentQuestionsFeed. - Apply a case sensitive unique index on the
namecolumn. I don't think there are Blueprint helpers for this in Laravel. You may have to doDB::raw(CREATE UNIQUE INDEX hashtags_name_unique ON hashtags (name COLLATE utf8mb4_bin);
… migration for collation
No description provided.