Potential fix for code scanning alert no. 39: Workflow does not contain permissions#132
Draft
pinkycollie wants to merge 6 commits into
Draft
Potential fix for code scanning alert no. 39: Workflow does not contain permissions#132pinkycollie wants to merge 6 commits into
pinkycollie wants to merge 6 commits into
Conversation
Signed-off-by: Pinky Collie <199848471+pinkycollie@users.noreply.github.com>
Signed-off-by: Pinky Collie <199848471+pinkycollie@users.noreply.github.com>
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Pinky Collie <199848471+pinkycollie@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/pinkycollie/deaf-first-platform/security/code-scanning/39
Add an explicit top-level
permissionsblock in.github/workflows/Security-hardening.ymlso all jobs inherit least-privilege token access unless overridden.Best single fix (without changing current functionality): define workflow-level read-only permissions:
contents: readThis is sufficient for current shown steps (checkout, setup-node, npm/grep shell checks) and matches CodeQL’s minimal recommended baseline. Place it after the
on:section (or near top-level keys) and beforejobs:so it applies globally across all jobs, including those omitted in the snippet.Suggested fixes powered by Copilot Autofix. Review carefully before merging.