Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ray data optimization] Make min num chunks to trigger combine configurable #36

Merged

Conversation

ShaochenYu-YW
Copy link

Combine chunks will be expensive and not needed as the number chunk won't be more than 10 or so. Note that this threshold has been updated to 10 in latest master on Ray. Signed-off-by: ShaochenYu-YW [email protected]

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…urable

Combine chunks will be expensive and not needed as the number chunk won't be more than 10 or so. Note that this threshold has been updated to 10 in latest master on Ray. Signed-off-by: ShaochenYu-YW <[email protected]>

Signed-off-by: ShaochenYu-YW <[email protected]>
@ShaochenYu-YW ShaochenYu-YW merged commit 5699d59 into pinterest/main-2.10.0 Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants