Merge pull request #73 from ambud/master

Add a metric to measure singer startup latency
pinterest · Aug 6, 2020 · 637936d · 637936d
2 parents ea3cd9c + 418cd53
commit 637936d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/singer/src/main/java/com/pinterest/singer/common/SingerMetrics.java b/singer/src/main/java/com/pinterest/singer/common/SingerMetrics.java
@@ -38,6 +38,7 @@ public class SingerMetrics {
   public static final String FILE_LOOKUP_FAILURE = "singer.file_lookup.failure";
 
   public static final String SINGER_START_INDICATOR = "singer.starting";
+  public static final String SINGER_STARTUP_LATENCY = "singer.startup.latency";
 
   public static final String NO_SUCH_FILE_EXCEPTION = "singer.singer_log.nosuchfileexception";
 

diff --git a/singer/src/main/java/com/pinterest/singer/common/SingerSettings.java b/singer/src/main/java/com/pinterest/singer/common/SingerSettings.java
@@ -112,7 +112,7 @@ public static void initialize(SingerConfig config)
              NoSuchMethodException,
       SingerLogException {
     setSingerConfig(config);
-
+    long startTs = System.currentTimeMillis();
     // mark metric if Singer is running in shadowMode
     if (config.isShadowModeEnabled()) {
       Stats.setGauge(SingerMetrics.SHADOW_MODE_ENABLED, 1);
@@ -216,7 +216,9 @@ public static void initialize(SingerConfig config)
       logMonitor = (LogMonitor) getInstanceMethod.invoke(null, monitorIntervalInSecs, singerConfig);
       logMonitor.start();
     }
-
+    long startupLatency = System.currentTimeMillis() - startTs;
+    Stats.setGauge(SingerMetrics.SINGER_STARTUP_LATENCY, startupLatency);
+
     globalFsm.start();
   }