Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JitterBuffer: Improve performance for SampleBuilder use #292

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thatsnotright
Copy link
Contributor

Description

This PR Should hopefully improve the performance for use by SampleBuilder and in the general case.

@at-wat If you have time would you be able to test this PR and the corresponding branch I created in the webrtc repository? pion/webrtc#2959

Thank you!

@thatsnotright thatsnotright requested a review from at-wat November 26, 2024 23:51
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 75.49858% with 86 lines in your changes missing coverage. Please review.

Project coverage is 69.46%. Comparing base (f2f92bb) to head (ab615fe).

Files with missing lines Patch % Lines
pkg/jitterbuffer/priority_queue.go 75.62% 64 Missing and 14 partials ⚠️
pkg/jitterbuffer/jitter_buffer.go 20.00% 4 Missing ⚠️
pkg/jitterbuffer/receiver_interceptor.go 80.95% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   71.69%   69.46%   -2.24%     
==========================================
  Files          79       79              
  Lines        4742     4961     +219     
==========================================
+ Hits         3400     3446      +46     
- Misses       1203     1355     +152     
- Partials      139      160      +21     
Flag Coverage Δ
go ?
wasm 69.46% <75.49%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat
Copy link
Member

at-wat commented Nov 27, 2024

I'll try it later!

@at-wat
Copy link
Member

at-wat commented Dec 10, 2024

@thatsnotright I tested this branch locally in my usecase and confirmed that SampleBuilder's performance is good! (mostly same CPU/memory usage as the latest release)

@thatsnotright
Copy link
Contributor Author

@thatsnotright I tested this branch locally in my usecase and confirmed that SampleBuilder's performance is good! (mostly same CPU/memory usage as the latest release)

@at-wat Thank you for taking the time to test, I appreciate your time! I'll clean up the code a little and make some test coverage improvements and then work with @Sean-Der on next steps!

Rework the jittebuffer for SampleBuilder use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants