Skip to content

Buffer packets when no RTCP writer is set - #458

Open
mengelbart wants to merge 1 commit into
mainfrom
fix/buffer-without-rtcp
Open

mengelbart wants to merge 1 commit into
mainfrom
fix/buffer-without-rtcp

Conversation

@mengelbart

Copy link
Copy Markdown
Contributor

No description provided.

@mengelbart
mengelbart requested a review from JoTurk September 8, 2026 08:49
@codecov

codecov Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.41%. Comparing base (33e6fc9) to head (fd7ae02).

Files with missing lines Patch % Lines
pkg/ccfb/interceptor.go 66.66% 3 Missing ⚠️
pkg/twcc/sender_interceptor.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   85.43%   85.41%   -0.03%     
==========================================
  Files          91       91              
  Lines        3976     3990      +14     
==========================================
+ Hits         3397     3408      +11     
- Misses        579      582       +3     
Flag Coverage Δ
go 85.41% <77.77%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mengelbart
mengelbart force-pushed the fix/buffer-without-rtcp branch 2 times, most recently from 536c5aa to ad8f21d Compare September 11, 2026 07:34
@mengelbart
mengelbart force-pushed the fix/buffer-without-rtcp branch from ad8f21d to fd7ae02 Compare September 24, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant