Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DialAssociation and ListenAssociation #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

backkem
Copy link
Member

@backkem backkem commented Jun 20, 2020

These are helpers to easily run SCTP over UDP. Example adapted.
I added the Association postfix to keep space for a potential
Dial/Listen implementation that directly gives you a Stream.

Relates to #74

TODO:

  • Tag pion/udp after landing CI
  • Change to SCTP over IP instead of over UDP.
  • Proper shutdown for the listener.

@backkem backkem requested a review from enobufs June 20, 2020 19:45
@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #126 into master will decrease coverage by 2.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   78.62%   76.22%   -2.40%     
==========================================
  Files          43       45       +2     
  Lines        2779     2869      +90     
==========================================
+ Hits         2185     2187       +2     
- Misses        459      548      +89     
+ Partials      135      134       -1     
Flag Coverage Δ
#go 76.22% <0.00%> (-2.40%) ⬇️
#wasm 67.82% <0.00%> (-3.57%) ⬇️
Impacted Files Coverage Δ
association.go 82.11% <0.00%> (-0.27%) ⬇️
chunk_payload_data.go 69.69% <ø> (ø)
dialer.go 0.00% <0.00%> (ø)
listener.go 0.00% <0.00%> (ø)
stream.go 86.28% <0.00%> (-5.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6d053...0dee1d0. Read the comment docs.

These are helpers to easily run SCTP over UDP. Example adapted.
I added the Association postfix to keep space for a potential
Dial/Listen implementation that directly gives you a Stream.

Relates to #74
@backkem

This comment has been minimized.

Dial & Listen with sane but over-writable defaults.

Relates to #74
@edaniels
Copy link
Member

hey @backkem we're starting to work on a v2, that could include SCTP support over not just DTLS. Is this something you'd like to work on getting in still?

@stv0g
Copy link
Member

stv0g commented Mar 1, 2024

I would be interested in SCTP over IP as well.

@edaniels How do plan to start the work on v2? Is there a separate branch?

@backkem
Copy link
Member Author

backkem commented Mar 1, 2024

@edaniels my original goal for pushing this was to make each protocol in the stack usable in their own right, not just for WebRTC. I don't have a use-case for this myself at the moment. Feel free to take this over.

@edaniels
Copy link
Member

edaniels commented Mar 1, 2024

@stv0g i think we can just cut to v2 whenever on master and if we need back ports make a v1 branch? What do you think?

@edaniels
Copy link
Member

edaniels commented Mar 1, 2024

Regarding an overall plan, don't quite have one yet but as long as we don't tag a release for it, we can be in flux API wise

@edaniels
Copy link
Member

edaniels commented Mar 1, 2024

@stv0g is making this work over IP something you'd want to take on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants