Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TURN client refactor #74

Closed
enobufs opened this issue Jul 11, 2019 · 0 comments · Fixed by #75
Closed

TURN client refactor #74

enobufs opened this issue Jul 11, 2019 · 0 comments · Fixed by #75
Assignees
@enobufs

Comments

@enobufs
Copy link
Member

enobufs commented Jul 11, 2019 •
edited
Loading

Summary

Issues:

  • Current pion/turnc behaves as “port-restricted” NAT
  • If the other end is a symmetric NAT, ICE cannot find a valid candidate pair
  • Current pion/turnc is overly complex to fix this

Related Issues on Github

Motivation

We will try to implement a new TURN client in a way that would solve all the above problems, without having to modify pion/turnc (would be hard).
The pion/turn has its own client but it does not support TURN protocol. It's a clean place to try out the new implementation of TURN client, while leaving the pion/turnc as is to leave us "two-way door".

Describe alternatives you've considered

Modify pion/turnc .... I have tried, but it is really complex. Abstraction of channel as a net.Conn has been found fundamentally intervening in allowing ICE to detect prflx candidate which is necessary to traverse remote symmetric NAT even local end uses TURN.

Additional context

Details of issues I have found and my refactoring plan is described here
enobufs added a commit that referenced this issue Jul 11, 2019
@enobufs
TURN client refactor
c3e0edb 
Refresh and ChannelBind are not implemented yet
Resolves #74
@enobufs enobufs self-assigned this Jul 11, 2019
@enobufs enobufs mentioned this issue Jul 11, 2019
Merged
enobufs added a commit that referenced this issue Jul 12, 2019
@enobufs
Implemented allocation & permission refresh
c1aaaa0 
Thread-safety optimization
Fixed lint errors
Fixed code per review feedback
Resolves #74
enobufs added a commit that referenced this issue Jul 12, 2019
@enobufs
Modification from review feedback
78d96fa 
Resolves #74
enobufs added a commit that referenced this issue Jul 12, 2019
@enobufs
Enable channel binding
6440fe0 
Further threa-safety improvements
Optimized inbound packet demuxing
Resolves #74
enobufs added a commit that referenced this issue Jul 12, 2019
@enobufs
TURN client refactor
956ae5a 
Implemented allocation & permission refresh
Implemented permissions
Implemented channel binding
Threa-safety improvements
Optimized inbound packet demuxing
Resolves #74
enobufs added a commit that referenced this issue Jul 13, 2019
@enobufs
TURN client refactor
07b0197 
Implemented allocation & permission refresh
Implemented permissions
Implemented channel binding
Threa-safety improvements
Optimized inbound packet demuxing
Resolves #74
enobufs added a commit that referenced this issue Jul 13, 2019
@enobufs
Rebase master at f0df9
5cb7edc 
Switched cofg.Software to a string
Fixed errors introduced by the last rebase
Resolves #74
enobufs added a commit that referenced this issue Jul 13, 2019
@enobufs
Switch to write lock
891c7eb 
Resolves #74
enobufs added a commit that referenced this issue Jul 13, 2019
@enobufs
Include num of retries in transaction result
882b39d 
Resolves #74
enobufs added a commit that referenced this issue Jul 14, 2019
@enobufs
Fixed many thread-safety issues
4378deb 
Resolves #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Fix all errors with coturn
dbb55e6 
* Requested Transport attr was add to non-allocate requests incorrectly
* Refresh request was missing username, realm, nonce and integrity
Resolves #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Update pion/transport to v0.8.5
aece117 
Resolve #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Fixed how things return per review feedback
c6db2e9 
Resolve #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
TURN client refactor
a50906b 
Implemented allocation & permission refresh
Implemented permissions
Implemented channel binding
Threa-safety improvements
Optimized inbound packet demuxing
Resolves #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Rebase master at f0df9
2c92c03 
Switched cofg.Software to a string
Fixed errors introduced by the last rebase
Resolves #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Switch to write lock
f95fbce 
Resolves #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Include num of retries in transaction result
02ee07e 
Resolves #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Fixed many thread-safety issues
a985012 
Resolves #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Fix all errors with coturn
accf9b7 
* Requested Transport attr was add to non-allocate requests incorrectly
* Refresh request was missing username, realm, nonce and integrity
Resolves #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Update pion/transport to v0.8.5
e17c143 
Resolve #74
enobufs added a commit that referenced this issue Jul 15, 2019
@enobufs
Fixed how things return per review feedback
cc616bb 
Resolve #74
enobufs added a commit to pion/webrtc that referenced this issue Jul 16, 2019
@enobufs
Update pion/ice to v0.5.1 (new TURN client)
9a8d492 
Relates to pion/turn#74
@enobufs enobufs mentioned this issue Jul 16, 2019
Merged
enobufs added a commit to pion/webrtc that referenced this issue Jul 17, 2019
@enobufs
Update ice to update-turn-to-v1.3.2 branch
2acea41 
Relates to pion/turn#74
Sean-Der pushed a commit to pion/webrtc that referenced this issue Jul 17, 2019
@enobufs @Sean-Der
Update pion/ice to v0.5.2
c7ba240 
Relates to pion/turn#74
Sean-Der pushed a commit to pion/webrtc that referenced this issue Jul 17, 2019
@enobufs @Sean-Der
Update pion/ice to v0.5.2
071d004 
Relates to pion/turn#74
Sean-Der added a commit to pion/webrtc that referenced this issue Jul 17, 2019
@Sean-Der
Update pion/ice to v0.5.2
d9334b9 
Relates to pion/turn#74
Sean-Der added a commit to pion/webrtc that referenced this issue Jul 17, 2019
@Sean-Der
Update pion/ice to v0.5.2
c1acddd 
Relates to pion/turn#74
ourwarmhouse added a commit to ourwarmhouse/Smart-Contract---Go that referenced this issue May 1, 2024
@ourwarmhouse
Update pion/ice to v0.5.2
682d424 
Relates to pion/turn#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enobufs enobufs

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TURN client refactor pion/turn
1 participant
@enobufs