Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update pion/ice to v0.5.x (new TURN client) #740

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

enobufs
Copy link
Member

@enobufs enobufs commented Jul 16, 2019

Relates to pion/turn#74

This updates pion/ice to v0.5.1, which include a refactoring of CandidateRelay and a TURN client overhaul which resolves the connectivity issue with relay-prflx (symmetric NAT) pair.

@enobufs
Copy link
Member Author

enobufs commented Jul 16, 2019

Hmm...

1.46s$ GOOS=js GOARCH=wasm go test -exec="./test-wasm/go_js_wasm_exec" -v .
# github.com/pion/turn/internal/ipnet
../../../gopath/pkg/mod/github.com/pion/[email protected]/internal/ipnet/ipv4.go:17:12: undefined: setControlMessage
../../../gopath/pkg/mod/github.com/pion/[email protected]/internal/ipnet/ipv4.go:32:8: undefined: createControlMessage
FAIL	github.com/pion/webrtc/v2 [build failed]
The command "GOOS=js GOARCH=wasm go test -exec="./test-wasm/go_js_wasm_exec" -v ." exited with 2.

@Sean-Der Any idea? I wonder why this happens at webrtc level. Actually, control message is no longer used in pion/turn. I may have to clearn that up, but I'd like to know exactly what this means.

@enobufs
Copy link
Member Author

enobufs commented Jul 16, 2019

Aggh... ok. I am going to completely remove ipnet folder:

internal/ipnet/ipv4.go:17:      if err := setControlMessage(conn); err != nil {
internal/ipnet/ipv4_unix.go:10:func setControlMessage(conn *ipv4.PacketConn) error {
internal/ipnet/ipv4_windows.go:9:func setControlMessage(conn *ipv4.PacketConn) error {

@enobufs enobufs changed the title Update pion/ice to v0.5.1 (new TURN client) [WIP] Update pion/ice to v0.5.x (new TURN client) Jul 17, 2019
enobufs added a commit to pion/turn that referenced this pull request Jul 17, 2019
Upgraded pion/transport to v0.8.6
Relates to pion/webrtc#740
enobufs added a commit to pion/turn that referenced this pull request Jul 17, 2019
Upgraded pion/transport to v0.8.6
Relates to pion/webrtc#740
enobufs added a commit to pion/turn that referenced this pull request Jul 17, 2019
Upgraded pion/transport to v0.8.6
Relates to pion/webrtc#740
enobufs added a commit to pion/ice that referenced this pull request Jul 17, 2019
Also update pion/transport to v0.8.6
Relates to pion/webrtc#740
enobufs added a commit to pion/ice that referenced this pull request Jul 17, 2019
TURN client's loc conn was not closed when agent.Close() was called
Relates to pion/webrtc#740
Sean-Der pushed a commit to pion/ice that referenced this pull request Jul 17, 2019
Also update pion/transport to v0.8.6
Relates to pion/webrtc#740
Sean-Der pushed a commit to pion/ice that referenced this pull request Jul 17, 2019
TURN client's loc conn was not closed when agent.Close() was called
Relates to pion/webrtc#740
@Sean-Der Sean-Der force-pushed the use_new_turn_client branch 2 times, most recently from c7ba240 to 071d004 Compare July 17, 2019 18:26
@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #740 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   76.71%   76.66%   -0.05%     
==========================================
  Files          58       59       +1     
  Lines        4041     4050       +9     
==========================================
+ Hits         3100     3105       +5     
- Misses        686      690       +4     
  Partials      255      255
Impacted Files Coverage Δ
sctptransport.go 74.34% <0%> (-1.32%) ⬇️
dtlstransport.go 66.66% <0%> (-1.17%) ⬇️
configuration.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7243561...d9334b9. Read the comment docs.

@Sean-Der Sean-Der merged commit c1acddd into master Jul 17, 2019
@Sean-Der Sean-Der deleted the use_new_turn_client branch July 17, 2019 19:22
@enobufs
Copy link
Member Author

enobufs commented Jul 17, 2019

Thanks! Let me tag it as v2.0.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants