Skip to content

Commit

Permalink
Revert breaking change in ICECandidateStats
Browse files Browse the repository at this point in the history
  • Loading branch information
hansgylling authored and Sean-Der committed Aug 18, 2023
1 parent cedd45f commit 1d12dc8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion stats.go
Original file line number Diff line number Diff line change
Expand Up @@ -1895,7 +1895,7 @@ type ICECandidateStats struct {
//
// DEPRECATED. Although it may still work in some browsers, the networkType property was deprecated for
// preserving privacy.
NetworkType string `json:"networkType,omitempty"`
NetworkType NetworkType `json:"networkType,omitempty"`

// IP is the IP address of the candidate, allowing for IPv4 addresses and
// IPv6 addresses, but fully qualified domain names (FQDNs) are not allowed.
Expand Down
4 changes: 2 additions & 2 deletions stats_go_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ func getStatsSamples() []statSample {
Type: StatsTypeLocalCandidate,
ID: "ILO8S8KYr",
TransportID: "T01",
NetworkType: "wifi",
NetworkType: NetworkTypeUDP4,
IP: "192.168.0.36",
Port: 65400,
Protocol: "udp",
Expand All @@ -820,7 +820,7 @@ func getStatsSamples() []statSample {
"type": "local-candidate",
"id": "ILO8S8KYr",
"transportId": "T01",
"networkType": "wifi",
"networkType": 1,
"ip": "192.168.0.36",
"port": 65400,
"protocol": "udp",
Expand Down

0 comments on commit 1d12dc8

Please sign in to comment.