Fix ssrc-group ordering #2925
Closed
Fix ssrc-group ordering #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSRCes were flipped incorrectly
|
Opening another PR. This is not the right fix -_- |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2925 +/- ##
===========================================
- Coverage 78.93% 64.65% -14.29%
===========================================
Files 89 67 -22
Lines 8564 3296 -5268
===========================================
- Hits 6760 2131 -4629
+ Misses 1314 1039 -275
+ Partials 490 126 -364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
boks1971
approved these changes
Oct 7, 2024
| @@ -393,11 +393,11 @@ func addSenderSDP( | |||
| sendParameters := sender.GetParameters() | |||
| for _, encoding := range sendParameters.Encodings { | |||
| if encoding.RTX.SSRC != 0 { | |||
| media = media.WithValueAttribute("ssrc-group", fmt.Sprintf("FID %d %d", encoding.SSRC, encoding.RTX.SSRC)) | |||
| media = media.WithValueAttribute("ssrc-group", fmt.Sprintf("FID %d %d", encoding.RTX.SSRC, encoding.SSRC)) | |||
There was a problem hiding this comment.
I thought it is primary first and then RTX like the code you had before. Do I remember it wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSRCes were flipped incorrectly
Fixes #2922