Repository navigation
docs: publish the Next.js example as a live demo - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Gives the Next.js example a live URL so it can be linked from the docs and shared. The example becomes a static export (
output: 'export',basePathand the feed URL taken fromBASE_PATH), and the docs workflow builds it withBASE_PATH=/shipdot/demo/nextand copiesout/into the Pages artifact. It will be served at https://pipe1os.github.io/shipdot/demo/next/.Without
BASE_PATHthe example behaves as before (src="/shipdot.json"). Thestartscript is removed becausenext startdoes not work with a static export.Checked locally: built with the base path, served under
/shipdot/demo/next/, the widget loadsshipdot.json(200), shows the badge and the hotspot on "Export CSV", no console errors.shipdot
skip
Checklist
pnpm lintpasses (typecheck and unit tests do not cover the example)pnpm test:e2epasses (if the widget changed): widget unchangedpnpm changeset(if a published package changed): no package changed